Skip to content

MAINT: upload all wheels simultaneously#49

Open
andyfaff wants to merge 1 commit intonumpy:mainfrom
andyfaff:artefact
Open

MAINT: upload all wheels simultaneously#49
andyfaff wants to merge 1 commit intonumpy:mainfrom
andyfaff:artefact

Conversation

@andyfaff
Copy link
Copy Markdown
Member

@andyfaff andyfaff commented May 7, 2026

Follows scipy-release behaviour in having all wheels being uploaded simultaneously in a separate step.

scipy-release seems to be working well after having transitioned to this model.

We might need to add an extra environment called none to satisfy the logic of when to upload on a manual trigger.

@andyfaff andyfaff linked an issue May 7, 2026 that may be closed by this pull request
@andyfaff
Copy link
Copy Markdown
Member Author

andyfaff commented May 7, 2026

In this repo settings I added an extra 'none' environment that can only deploy when it's built on the main branch.
The workflow_dispatch (i.e. manual trigger) can upload to nightly if the none environment is used during the triggering. There will be a further approval before upload occurs.

The scheduled cron job should be unaffected.

@rgommers
Copy link
Copy Markdown
Member

rgommers commented May 8, 2026

There will be a further approval before upload occurs.

That doesn't seem to be configured - and that's fine, it's unnecessary in my opinion. If you trigger a workflow on main, that's what you want, so no need for an extra gate I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider changing how nightlies are uploaded

2 participants