Skip to content

fix(icons): provide a full dummy path as generic filename#2456

Closed
abeldekat wants to merge 1 commit into
nvim-mini:mainfrom
abeldekat:fix_icons
Closed

fix(icons): provide a full dummy path as generic filename#2456
abeldekat wants to merge 1 commit into
nvim-mini:mainfrom
abeldekat:fix_icons

Conversation

@abeldekat

Copy link
Copy Markdown
Member

Resolve #2455

When the cwd is deleted, vim.filetype.match fails when MiniIcons queries with filename aaa.<the_extension>.

Solution: Add a /

@echasnovski, a test is in the making...

@abeldekat abeldekat marked this pull request as draft June 10, 2026 08:27
@echasnovski

echasnovski commented Jun 10, 2026

Copy link
Copy Markdown
Member

Thanks for the PR!

Solution: Add a /

I don't think this is the best approach here, as 1) this might be Unix specific, and 2) using files in root directory can have permission issues.

My first idea was to use pcall somewhere, but I didn't have time to test it yet.

@abeldekat

Copy link
Copy Markdown
Member Author

I don't think this is the best approach here, ...

Yes, you are right. Closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash in mini.icons when using mini.tabline and cwd does not exist

2 participants