Adds eslint settings to ignore mocha/chai#357
Open
AndrewO wants to merge 1 commit intoolivernn:masterfrom
Open
Adds eslint settings to ignore mocha/chai#357AndrewO wants to merge 1 commit intoolivernn:masterfrom
AndrewO wants to merge 1 commit intoolivernn:masterfrom
Conversation
Author
|
I didn't change anything in the test that's breaking now... any idea why the build failed? |
AndrewO
force-pushed
the
eslint_mocha
branch
2 times, most recently
from
9dd87ae to
29dac17
Compare
Author
|
The breaking test is unrelated. The |
Owner
|
Yeah, the current build system has a few warts. What exactly does this change do? Suppress warnings about mocha/chai related globals? |
Author
|
Yeah. It also reported a typo in some comments on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Red squiggles for
test,suite, andassertall go away in VS Code + ESLint plugin with these changes.