Introduce reverse in Fixed/Variable sized Array type#2654
Merged
Conversation
darkdrag00nv2
requested review from
SupunS,
dsainati1 and
turbolent
as code owners
6 tasks
Contributor
|
Nit: I'm not sold on the naming here. How about having this reverse-and-copy function be called |
Codecov Report
@@ Coverage Diff @@
## master #2654 +/- ##
==========================================
+ Coverage 78.53% 78.57% +0.03%
==========================================
Files 338 338
Lines 78143 78217 +74
==========================================
+ Hits 61373 61457 +84
+ Misses 14483 14474 -9
+ Partials 2287 2286 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
Author
|
@dsainati1 I was trying to follow the Swift convention but your suggestion does sound clearer. Will update this and the other PR accordingly. |
darkdrag00nv2
force-pushed
the
reversed_array
branch
from
efc9ece to
d0e2019
Compare
darkdrag00nv2
changed the title
reversed in Fixed/Variable sized Array typereverse in Fixed/Variable sized Array type
SupunS
reviewed
Jul 14, 2023
Co-authored-by: Supun Setunga <supun.setunga@gmail.com>
darkdrag00nv2
force-pushed
the
reversed_array
branch
from
1cfdc6e to
344ce6a
Compare
SupunS
approved these changes
Jul 18, 2023
SupunS
left a comment
SupunS
left a comment
Member
There was a problem hiding this comment.
LGTM! Just some minor suggestions
Co-authored-by: Supun Setunga <supun.setunga@gmail.com>
Co-authored-by: Supun Setunga <supun.setunga@gmail.com>
SupunS
approved these changes
Jul 19, 2023
dsainati1
approved these changes
Jul 19, 2023
7 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #2605
Description
Introduce
reversefunction for creating a copy of a Variable/Fixed size Array value with its entries reversed.This function would be unavailable to resource arrays since resources cannot be copied.
Will send docs PR post the merge.
masterbranchFiles changedin the Github PR explorer