Skip to content

Fixes scala-reflect issue with GitHub pureconfig (https://github.com/opalj/JCG/issues/17) #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
errt merged 4 commits into from
May 12, 2026
Merged

Fixes scala-reflect issue with GitHub pureconfig (https://github.com/opalj/JCG/issues/17) #362

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4fd23d1
Implement ConfigReader[EntryPointContainer] manually to avoid issue w…
svenkeidel May 12, 2026
7c50e9c
Accept EntryPointContainer "declaring-class" and "declaringClass" keys
svenkeidel May 12, 2026
2a613d6
Only accept EntryPointContainer.declaring-class keys
svenkeidel May 12, 2026
4607733
Fix documentation
svenkeidel May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions OPAL/br/src/main/scala/org/opalj/br/analyses/cg/EntryPointFinder.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,8 @@ trait LibraryEntryPointsFinder extends EntryPointFinder {
* InitialEntryPointKey {
* analysis = "org.opalj.br.analyses.cg.ConfigurationEntryPointsFinder"
* entryPoints = [
* {declaringClass = "java/util/List+", name = "add"},
* {declaringClass = "java/util/List", name = "remove", descriptor = "(I)Z"}
* {declaring-class = "java/util/List+", name = "add"},
* {declaring-class = "java/util/List", name = "remove", descriptor = "(I)Z"}
* ]
* }
* }
Expand All @@ -245,7 +245,7 @@ trait LibraryEntryPointsFinder extends EntryPointFinder {
* Please note that the first entry point, by adding the "+" to the declaring class' name, considers
* all "add" methods from all subtypes independently of the respective method's descriptor. In
* contrast, the second entry does specify a descriptor and does not consider List's subtypes (by
* not suffixing a plus to the declaringClass) which implies that only the remove method with this
* not suffixing a plus to the declaring-class) which implies that only the remove method with this
* descriptor is considered as entry point.
*
* @author Michael Reif
Expand Down Expand Up @@ -376,7 +376,11 @@ trait ConfigurationEntryPointsFinder extends EntryPointFinder {
declaringClass: String,
name: String,
descriptor: Option[String]
) derives ConfigReader
)

// Implement ConfigReader manually to avoid issue with scala-reflect: https://github.com/opalj/JCG/issues/17
private implicit val entryPointContainerReader: ConfigReader[EntryPointContainer] =
ConfigReader.forProduct3("declaring-class", "name", "descriptor")(EntryPointContainer.apply)
}

/**
Expand Down