feat(condo): DOMA-13361 add region messenger link#7822
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughAdds a region messenger employee bot link exposed through runtime config and rendered in user settings with updated styling and locale strings. Also updates the .helm submodule reference. ChangesRegion Messenger Bot Feature
Estimated code review effort: 2 (Simple) | ~15 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. 🔧 Stylelint (17.14.0)apps/condo/domains/user/components/UserSettingsContent.module.cssConfigurationError: Could not find "stylelint-config-rational-order". Do you need to install the package or use the "configBasedir" option? Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
♻️ Duplicate comments (1)
apps/condo/domains/user/components/UserSettingsContent.tsx (1)
437-441: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winSame className mismatch as
UserSettingsContent.module.css.
styles.botLinkTitle/styles.botLinkTooltipIconreference camelCase properties, but the CSS module defines kebab-case selectors (.bot-link-title,.bot-link-tooltip-icon). See the companion comment onUserSettingsContent.module.cssfor the root cause and fix.Also applies to: 467-475
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/condo/domains/user/components/UserSettingsContent.tsx` around lines 437 - 441, The JSX in UserSettingsContent is using the wrong CSS module keys for the bot link title and tooltip icon. Update UserSettingsContent to use the class names that match the selectors defined in UserSettingsContent.module.css for the bot link title/tooltip icon elements, and apply the same fix to the other affected bot link block referenced in UserSettingsContent. Keep the identifiers aligned with the module’s exported names so styles resolve correctly.
🧹 Nitpick comments (1)
apps/condo/domains/user/components/UserSettingsContent.tsx (1)
431-489: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDuplicated bot-link row markup between Telegram and region-messenger sections.
The Telegram bot block (Lines 431-459) and the new region-messenger block (Lines 461-489) are structurally identical (title span + tooltip icon +
Typography.Link), differing only in the title/message/href/id values. Consider extracting a small sharedBotLinkRowcomponent to avoid duplicating this JSX.♻️ Sketch of a shared component
type BotLinkRowProps = { title: string tooltip: string openMessage: string href: string id: string } const BotLinkRow: React.FC<BotLinkRowProps> = ({ title, tooltip, openMessage, href, id }) => ( <Col span={24}> <Row align='middle'> <Col lg={5} xs={10}> <Typography.Text type='secondary'> <span className={styles.botLinkTitle}>{title}</span> <Tooltip title={tooltip}> <span className={styles.botLinkTooltipIcon}> <Info size='small' /> </span> </Tooltip> </Typography.Text> </Col> <Col lg={18} xs={10} offset={1}> <Typography.Link href={href} target='_blank' id={id}> {openMessage} </Typography.Link> </Col> </Row> </Col> )🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/condo/domains/user/components/UserSettingsContent.tsx` around lines 431 - 489, The Telegram and region-messenger bot link sections in UserSettingsContent are duplicated JSX with only labels, href, and ids changing. Extract the repeated layout into a shared BotLinkRow component (or equivalent helper) and pass in title, tooltip, openMessage, href, and id props, then reuse it for both telegramEmployeeBotName and regionMessengerEmployeeBotLink branches.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@apps/condo/domains/user/components/UserSettingsContent.tsx`:
- Around line 437-441: The JSX in UserSettingsContent is using the wrong CSS
module keys for the bot link title and tooltip icon. Update UserSettingsContent
to use the class names that match the selectors defined in
UserSettingsContent.module.css for the bot link title/tooltip icon elements, and
apply the same fix to the other affected bot link block referenced in
UserSettingsContent. Keep the identifiers aligned with the module’s exported
names so styles resolve correctly.
---
Nitpick comments:
In `@apps/condo/domains/user/components/UserSettingsContent.tsx`:
- Around line 431-489: The Telegram and region-messenger bot link sections in
UserSettingsContent are duplicated JSX with only labels, href, and ids changing.
Extract the repeated layout into a shared BotLinkRow component (or equivalent
helper) and pass in title, tooltip, openMessage, href, and id props, then reuse
it for both telegramEmployeeBotName and regionMessengerEmployeeBotLink branches.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4f9a6d44-5454-4dc0-aadd-a5923efbdd9d
📒 Files selected for processing (7)
.helmapps/condo/domains/user/components/UserSettingsContent.module.cssapps/condo/domains/user/components/UserSettingsContent.tsxapps/condo/lang/en/en.jsonapps/condo/lang/es/es.jsonapps/condo/lang/ru/ru.jsonapps/condo/next.config.ts
Alexander-Turkin
force-pushed
the
feat/condo/DOMA-13361/add-messenger-link
branch
from
64a42ea to
33673a7
Compare
| const cardIssuerImages = JSON.parse(conf['CARD_ISSUER_IMAGES'] || '{}') | ||
| const hCaptchaSiteKey = conf['HCAPTCHA_CONFIG'] ? { SITE_KEY: hCaptcha['SITE_KEY'] } : {} | ||
| const subscriptionProgressModalConfig = JSON.parse(conf['SUBSCRIPTION_PROGRESS_MODAL_CONFIG'] || '{}') | ||
| const regionMessengerEmployeeBotLink = conf['REGION_MESSENGER_EMPLOYEE_BOT_LINK'] |
There was a problem hiding this comment.
we can just call it messenger, but ok
Alexander-Turkin
force-pushed
the
feat/condo/DOMA-13361/add-messenger-link
branch
from
33673a7 to
84970ab
Compare
|
3 participants
Summary by CodeRabbit