feat(opentelemetry-collector): support sampleLimit in servicemonitor#2152
Open
oliviermichaelis wants to merge 3 commits intoopen-telemetry:mainfrom
Open
feat(opentelemetry-collector): support sampleLimit in servicemonitor#2152oliviermichaelis wants to merge 3 commits intoopen-telemetry:mainfrom
oliviermichaelis wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
oliviermichaelis
requested review from
a team,
TylerHelmuth,
dmitryax and
povilasv
as code owners
jaronoff97
reviewed
Apr 16, 2026
| apiVersion: v2 | ||
| name: opentelemetry-collector | ||
| version: 0.150.0 | ||
| version: 0.151.0 |
Contributor
There was a problem hiding this comment.
please bump the patch version and rerun make generate CHARTS=opentelemetry-collector
Author
There was a problem hiding this comment.
I thought this would be a minor version change (it's a backward-compatible feature, not a bug fix according to semver 2.0), therefore I chose 0.151.0 :)
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for configuring the
sampleLimitin the ServiceMonitor CustomResource (see the docs).I hope I've bumped the chart version accordingly.
I've used the following command to test the feature locally:
helm template test charts/opentelemetry-collector --set serviceMonitor.enabled=true --set image.repository=otel/opentelemetry-collector --set mode=deployment --show-only templates/servicemonitor.yaml --set serviceMonitor.sampleLimit=500000Thank you! :)