Fix VPA updateMode YAML parsing by adding quotes#2170
Open
DaStru wants to merge 2 commits intoopen-telemetry:mainfrom
Open
Fix VPA updateMode YAML parsing by adding quotes#2170DaStru wants to merge 2 commits intoopen-telemetry:mainfrom
DaStru wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
DaStru
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VPA templates render updateMode without quotes, causing it to be interpreted as a boolean in YAML 1.1. This breaks deployments on clusters with strict VPA webhook validation (like GKE) with the error:
admission webhook "gke-vpa.k8s.io" denied the request: json: cannot unmarshal bool into Go struct field PodUpdatePolicy.spec.updatePolicy.updateMode of type v1.UpdateModeThe issue occurs when users set
updateMode: "Off"in values - it gets rendered as unquotedupdateMode: Off, which YAML interprets as the booleanfalse. The VPA API expects a string enum value.This fix adds the
| quoteHelm filter to ensure the value is always rendered as a properly quoted string.