feat: #3017 add ValkeySession provider for session memory#3018
Draft
daric93 wants to merge 2 commits intoopenai:mainfrom
Draft
feat: #3017 add ValkeySession provider for session memory#3018daric93 wants to merge 2 commits intoopenai:mainfrom
daric93 wants to merge 2 commits intoopenai:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69e4857431
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Member
|
As I mentioned at #3017 (comment), we don't plan to add this in the short term, but we may revisit it if many developers need it. |
Signed-off-by: Daria Korenieva <daric2612@gmail.com>
69e4857 to
841e294
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3017
Summary
Adds ValkeySession, a session memory backend using the Valkey-GLIDE client library. Follows the same patterns as RedisSession — implements the Session protocol, supports TTL, from_url factory, client ownership tracking, and pipelined writes via Batch.
Changes