fix: reject string-like shell commands#3092
Open
Aphroq wants to merge 1 commit intoopenai:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes shell call command normalization when the model returns a string-like
action.commandspayload.str,bytes, andbytearrayvalues incoerce_shell_call()instead of treating them as generic sequencesModelBehaviorErrorbefore malformed payloads can be split into character-by-character commandscommandspayloads while keeping valid list-based shell calls unchangedTest plan
uv run pytest tests/test_shell_call_serialization.pybash .agents/skills/code-change-verification/scripts/run.shIssue number
Closes #3091
Checks
make lintandmake format