Skip to content

dynamic versioning#100

Merged
peterdudfield merged 3 commits intoopenclimatefix:mainfrom
ram-from-tvl:dynamic-versioning
Sep 17, 2025
Merged

dynamic versioning#100
peterdudfield merged 3 commits intoopenclimatefix:mainfrom
ram-from-tvl:dynamic-versioning

Conversation

@ram-from-tvl
Copy link
Copy Markdown
Contributor

Fixes #84

@ram-from-tvl
Copy link
Copy Markdown
Contributor Author

Hi @peterdudfield
Please review it and let me know if its good to go.
Thankyou!

@ram-from-tvl
Copy link
Copy Markdown
Contributor Author

Hi @peterdudfield
Any updates on this PR. please let me know if any changes are required..?
Thank you!

@siddharth7113
Copy link
Copy Markdown
Contributor

@peterdudfield Would it be possuble for you to review this issue?

@peterdudfield
Copy link
Copy Markdown
Contributor

hey @ram-from-tvl, thanks for this

ive added the tag v0.1.1., do you mind checking this works

Comment thread tests/test_metadata.py Outdated
@ram-from-tvl
Copy link
Copy Markdown
Contributor Author

Hi @peterdudfield
I have removed those lines. Please review it and let me know if any changes are required.
Thank you!

@peterdudfield
Copy link
Copy Markdown
Contributor

hey @ram-from-tvl, thanks for this

ive added the tag v0.1.1., do you mind checking this works

Have you checked it works, with this latest tag?

@ram-from-tvl
Copy link
Copy Markdown
Contributor Author

hey @ram-from-tvl, thanks for this
ive added the tag v0.1.1., do you mind checking this works

Have you checked it works, with this latest tag?

image Screenshot from 2025-09-17 14-53-59

I could see its working locally @peterdudfield. Please let me know if its good to go.
Thank you!

@peterdudfield
Copy link
Copy Markdown
Contributor

hey @ram-from-tvl, thanks for this
ive added the tag v0.1.1., do you mind checking this works

Have you checked it works, with this latest tag?

image Screenshot from 2025-09-17 14-53-59
I could see its working locally @peterdudfield. Please let me know if its good to go. Thank you!

Why do you have to add is as a system path?

@ram-from-tvl
Copy link
Copy Markdown
Contributor Author

@peterdudfield the sys.path was just for local testing without proper installation. The dynamic versioning works correctly with the build test showing open_data_pvnet-0.1.1-py3-none-any.whl built successfully, confirming the version is properly sourced from __init__.py.

@peterdudfield peterdudfield merged commit 89cd8e0 into openclimatefix:main Sep 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version Management Fix

3 participants