PVnet configs and save sample scripts#101
Merged
peterdudfield merged 6 commits intoopenclimatefix:mainfrom Aug 29, 2025
Merged
Conversation
Contributor
Author
|
@peterdudfield whenever possible please review. |
Contributor
|
you might have to pin zarr<3 in this version, to get tests working |
Contributor
|
This looks rgeat. Did you also test by running and training pvnet? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
- Coverage 49.70% 45.72% -3.99%
==========================================
Files 15 16 +1
Lines 1034 1124 +90
==========================================
Hits 514 514
- Misses 520 610 +90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@peterdudfield The configs looks good to me, I think we can merge this to main. |
peterdudfield
approved these changes
Aug 21, 2025
Contributor
|
@all-contributors please add @siddharth7113 for code |
Contributor
|
I've put up a pull request to add @siddharth7113! 🎉 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR include the following things :
save_samples.pyto create samples from gfs and gsp data.gitignorefor dealing with created samples.ocf-data-samplerandPVnetto ensure stability and compatibility.Fixes # #97 #62 #8
How Has This Been Tested?
Tested by creating samples using the
save_samplesscripts.Checklist: