Skip to content

PVnet configs and save sample scripts#101

Merged
peterdudfield merged 6 commits intoopenclimatefix:mainfrom
siddharth7113:pvnet_pip
Aug 29, 2025
Merged

PVnet configs and save sample scripts#101
peterdudfield merged 6 commits intoopenclimatefix:mainfrom
siddharth7113:pvnet_pip

Conversation

@siddharth7113
Copy link
Copy Markdown
Contributor

@siddharth7113 siddharth7113 commented Aug 19, 2025

Pull Request

Description

This PR include the following things :

  • Working configs for PVnet with GFS data
  • save_samples.py to create samples from gfs and gsp data.
  • Modifications in gitignore for dealing with created samples.
  • pining version of ocf-data-sampler and PVnet to ensure stability and compatibility.

Fixes # #97 #62 #8

How Has This Been Tested?

Tested by creating samples using the save_samples scripts.

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@siddharth7113
Copy link
Copy Markdown
Contributor Author

@peterdudfield whenever possible please review.

@peterdudfield
Copy link
Copy Markdown
Contributor

you might have to pin zarr<3 in this version, to get tests working

@peterdudfield
Copy link
Copy Markdown
Contributor

This looks rgeat. Did you also test by running and training pvnet?

Comment thread pyproject.toml
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 0% with 79 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.72%. Comparing base (75cf623) to head (8e7d464).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
src/open_data_pvnet/scripts/save_samples.py 0.00% 79 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   49.70%   45.72%   -3.99%     
==========================================
  Files          15       16       +1     
  Lines        1034     1124      +90     
==========================================
  Hits          514      514              
- Misses        520      610      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@siddharth7113
Copy link
Copy Markdown
Contributor Author

@peterdudfield The configs looks good to me, I think we can merge this to main.

@peterdudfield peterdudfield merged commit 38188b9 into openclimatefix:main Aug 29, 2025
1 of 4 checks passed
@peterdudfield
Copy link
Copy Markdown
Contributor

@all-contributors please add @siddharth7113 for code

@allcontributors
Copy link
Copy Markdown
Contributor

@peterdudfield

I've put up a pull request to add @siddharth7113! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants