8347377: Add validation checks for ICC_Profile header fields

[jankratochvil]

ICC_Profile header is validated too late leading later to unexpected exceptions.
A testcase is included.
It is not a clean backport - it has to change return switch expressions to their old format.
This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle.
It requires #3088 as a prerequisite.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8347377 needs maintainer approval

Warning

 ⚠️ Patch contains a binary file (test/jdk/java/awt/color/ICC_Profile/ValidateICCHeaderData/invalidSRGB.icc)

Issue

• JDK-8347377: Add validation checks for ICC_Profile header fields (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3089/head:pull/3089
$ git checkout pull/3089

Update a local copy of the PR:
$ git checkout pull/3089
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3089/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3089

View PR using the GUI difftool:
$ git pr show -t 3089

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3089.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into pr/3088 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (311fbfeb)
• 01: Full - Incremental (0d831417)
• 00: Full (0d831417)

[jankratochvil]

The CI failure of macos-x64 is a false positive:

Downloading single artifact
Error: Unable to download artifact(s): Artifact not found for name: bundles-macos-x64
        Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact.
        For more information, visit the GitHub Artifacts FAQ: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md

[bridgekeeper]

@jankratochvil This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8263622-8347377
git fetch https://git.openjdk.org/jdk11u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[bridgekeeper]

@jankratochvil This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[gnu-andrew]

Can we reopen this one and get it in? Thanks.

[jankratochvil]

/open

[openjdk]

@jankratochvil This pull request is now open

[phohensee]

Needs to be remerged in light of #3088. Otherwise looks good.

[jankratochvil]

The macos-aarch64 failure is a false positive:

error: invalid argument '-std=gnu23' not allowed with 'C++'

[phohensee]

Looks like you've imported part of JDK-8263051 in ICC_ColorSpace.java. If you're not going to import that, better to change the 2 lines in the original commit and leave the formatting alone.

Other than that, good.

[bridgekeeper]

@jankratochvil This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!