Skip to content

fix: use LocalTagReferencePolicy for input image tags #5139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Prucek wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use LocalTagReferencePolicy for input image tags #5139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/steps/input_image_tag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ func (s *inputImageTagStep) run(ctx context.Context) error {
},
Tag: &imagev1.TagReference{
ReferencePolicy: imagev1.TagReferencePolicy{
Type: imagev1.SourceTagReferencePolicy,
Type: imagev1.LocalTagReferencePolicy,
},
From: from,
ImportPolicy: imagev1.TagImportPolicy{
Expand Down
4 changes: 2 additions & 2 deletions pkg/steps/input_image_tag_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ func TestInputImageTagStep(t *testing.T) {
ImportMode: imagev1.ImportModePreserveOriginal,
},
ReferencePolicy: imagev1.TagReferencePolicy{
Type: imagev1.SourceTagReferencePolicy,
Type: imagev1.LocalTagReferencePolicy,
},
},
}
Expand Down Expand Up @@ -233,7 +233,7 @@ func TestInputImageTagStepExternal(t *testing.T) {
ImportMode: imagev1.ImportModePreserveOriginal,
},
ReferencePolicy: imagev1.TagReferencePolicy{
Type: imagev1.SourceTagReferencePolicy,
Type: imagev1.LocalTagReferencePolicy,
},
},
}
Expand Down
9 changes: 9 additions & 0 deletions pkg/steps/source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,11 @@ func handleFailedBuild(ctx context.Context, client BuildClient, ns, name string,
return err
}

if isNonRetriableInfraError(b.Status.LogSnippet) {
logrus.Infof("Build %s failed with non-retriable infrastructure error (%s), will not be retried", name, b.Status.Reason)
return err
}

logrus.Infof("Build %s previously failed from an infrastructure error (%s), retrying...", name, b.Status.Reason)

// Remove workload from metrics watching since we're about to delete and recreate the build
Expand Down Expand Up @@ -632,6 +637,10 @@ func isInfraReason(reason buildapi.StatusReason) bool {
return false
}

func isNonRetriableInfraError(logSnippet string) bool {
return strings.Contains(logSnippet, "manifest unknown")
}

func hintsAtInfraReason(logSnippet string) bool {
return strings.Contains(logSnippet, "error: build error: no such image") ||
strings.Contains(logSnippet, "[Errno 256] No more mirrors to try.") ||
Expand Down