METAL-1837: upgrade pre-submit for CBO OOC#79575
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@iurygregory: This pull request references METAL-1837 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
needs-rebase
WalkthroughTwo new baremetal operator upgrade test scenarios are added to the CI configuration: an IPv4 OVN variant and an OVN IPv6 variant. Both are optional, out-of-change tests targeting the equinix-ocp-metal cluster profile, with upgrade-specific release images and environment variables. ChangesBaremetal upgrade test scenarios
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@iurygregory, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/cluster-baremetal-operator/openshift-cluster-baremetal-operator-master.yaml`:
- Around line 103-115: The new presubmit entries
e2e-metal-ipi-upgrade-out-of-change and
e2e-metal-ipi-upgrade-ovn-ipv6-out-of-change were added to the cluster config
but the downstream generated job files were not updated; run make update to
regenerate the CI artifacts and commit the resulting changes so the new jobs
(referenced by those test names and the workflow
baremetalds-e2e-upgrade-ovn-ipv4) are reflected in
openshift-cluster-baremetal-operator-master-presubmits.yaml, then add and commit
the updated generated files.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 2b5f4d0f-1e9f-48bf-9f39-5d6455c58586
📒 Files selected for processing (1)
ci-operator/config/openshift/cluster-baremetal-operator/openshift-cluster-baremetal-operator-master.yaml
| - as: e2e-metal-ipi-upgrade-out-of-change | ||
| cluster: build05 | ||
| optional: true | ||
| skip_if_only_changed: \.md$|^(DCO|LICENSE|OWNERS|PROJECT)$ | ||
| steps: | ||
| cluster_profile: equinix-ocp-metal | ||
| dependencies: | ||
| OPENSHIFT_INSTALL_RELEASE_IMAGE: release:latest | ||
| OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: release:initial | ||
| env: | ||
| CLUSTERTYPE: baremetal | ||
| RUN_UPGRADE_TEST: "true" | ||
| workflow: baremetalds-e2e-upgrade-ovn-ipv4 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# 1) Regenerate ci-operator artifacts
make update
# 2) Show whether regeneration produced required changes
git status --short
git diff -- ci-operator/jobs ci-operator/config | sed -n '1,220p'Repository: openshift/release
Length of output: 106
🏁 Script executed:
# 1) Verify the file exists and check its content
ls -la ci-operator/config/openshift/cluster-baremetal-operator/openshift-cluster-baremetal-operator-master.yaml
# 2) Show the file content around lines 103-136
echo "=== Lines 100-140 of the file ==="
sed -n '100,140p' ci-operator/config/openshift/cluster-baremetal-operator/openshift-cluster-baremetal-operator-master.yaml
# 3) Check if corresponding job files exist in ci-operator/jobs/
echo -e "\n=== Check for job files related to these test names ==="
find ci-operator/jobs -name "*baremetal*" -type f | head -20Repository: openshift/release
Length of output: 3896
🏁 Script executed:
# 4) Look for the specific test names in the jobs directory
echo "=== Searching for 'e2e-metal-ipi-upgrade-out-of-change' test definition ==="
rg "e2e-metal-ipi-upgrade-out-of-change" ci-operator/jobs/ -l 2>/dev/null || echo "Not found in jobs/"
# 5) Check the structure of ci-operator/jobs directory for this repo
echo -e "\n=== Listing ci-operator/jobs/openshift/cluster-baremetal-operator/ ==="
ls -la ci-operator/jobs/openshift/cluster-baremetal-operator/ 2>/dev/null | head -30Repository: openshift/release
Length of output: 3469
🏁 Script executed:
echo "=== Searching for 'e2e-metal-ipi-upgrade-out-of-change' in presubmits file ==="
rg "e2e-metal-ipi-upgrade-out-of-change" ci-operator/jobs/openshift/cluster-baremetal-operator/openshift-cluster-baremetal-operator-master-presubmits.yaml -i
echo -e "\n=== Searching for 'e2e-metal-ipi-upgrade-ovn-ipv6-out-of-change' in presubmits file ==="
rg "e2e-metal-ipi-upgrade-ovn-ipv6-out-of-change" ci-operator/jobs/openshift/cluster-baremetal-operator/openshift-cluster-baremetal-operator-master-presubmits.yaml -i
echo -e "\n=== Check line count and sample of presubmits file ==="
wc -l ci-operator/jobs/openshift/cluster-baremetal-operator/openshift-cluster-baremetal-operator-master-presubmits.yaml
head -50 ci-operator/jobs/openshift/cluster-baremetal-operator/openshift-cluster-baremetal-operator-master-presubmits.yamlRepository: openshift/release
Length of output: 2151
🏁 Script executed:
# Verify that the presubmits file contains other test definitions to confirm it's properly generated
echo "=== Searching for other test names in presubmits to confirm generation is working ==="
rg "name: pull-ci-openshift-cluster-baremetal-operator-master" ci-operator/jobs/openshift/cluster-baremetal-operator/openshift-cluster-baremetal-operator-master-presubmits.yaml | head -15
# Count how many tests are defined
echo -e "\n=== Total test count in presubmits ==="
rg "name: pull-ci-openshift-cluster-baremetal-operator-master" ci-operator/jobs/openshift/cluster-baremetal-operator/openshift-cluster-baremetal-operator-master-presubmits.yaml | wc -l
# Count test entries in config
echo -e "\n=== Total test count in config file ==="
rg "^- as:" ci-operator/config/openshift/cluster-baremetal-operator/openshift-cluster-baremetal-operator-master.yaml | wc -lRepository: openshift/release
Length of output: 1426
Run make update to regenerate and commit CI downstream artifacts.
The new test entries e2e-metal-ipi-upgrade-out-of-change and e2e-metal-ipi-upgrade-ovn-ipv6-out-of-change are present in the config file but do not appear in the generated job files (openshift-cluster-baremetal-operator-master-presubmits.yaml). Per the CI configuration guidelines, structural changes to CI config files must be followed by running make update to regenerate and commit the downstream job artifacts before merging.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/cluster-baremetal-operator/openshift-cluster-baremetal-operator-master.yaml`
around lines 103 - 115, The new presubmit entries
e2e-metal-ipi-upgrade-out-of-change and
e2e-metal-ipi-upgrade-ovn-ipv6-out-of-change were added to the cluster config
but the downstream generated job files were not updated; run make update to
regenerate the CI artifacts and commit the resulting changes so the new jobs
(referenced by those test names and the workflow
baremetalds-e2e-upgrade-ovn-ipv4) are reflected in
openshift-cluster-baremetal-operator-master-presubmits.yaml, then add and commit
the updated generated files.
This commit adds two new upgrade pre-submit jobs to CBO They will test the case where the initial cluster is installed with the code from PRs. Assisted-By: Claude 4.6 Opus High Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
iurygregory
force-pushed
the
cbo-upgrade-pre-submit
branch
from
fe29d9f to
40a3b89
Compare
openshift-ci
Bot
removed
the
needs-rebase
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@iurygregory: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: honza, hroyrh, iurygregory The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse ack |
|
@iurygregory: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
4 participants
Assisted-By: Claude 4.6 Opus High
Summary by CodeRabbit