DPTP-2938: set authoritative admission flags false on pod-scaler

[deepsm007]

Wires the new authoritative flags on build-cluster pod-scaler admission. Both stay off so nothing changes in behavior yet.

Depends on openshift/ci-tools#4886 — that PR adds --authoritative-cpu and --authoritative-memory to pod-scaler.

Change: clusters/build-clusters/common/pod-scaler/pod-scaler-admission.yaml

• --authoritative-cpu=false
• --authoritative-memory=false

Only the common admission deployment (build01–13 path). vsphere02 is unchanged.

/hold
/cc @openshift/test-platform

Summary by CodeRabbit

This PR adds preparatory wiring for new authoritative admission flags to the pod-scaler admission webhook that runs on OpenShift build clusters.

What changed:

• Modified clusters/build-clusters/common/pod-scaler/pod-scaler-admission.yaml to add two new command-line arguments to the pod-scaler admission container:
  • --authoritative-cpu=false
  • --authoritative-memory=false

Impact:

• Affects the pod-scaler admission webhook deployed across build clusters 01–13 (via the common configuration)
• The vsphere02 build cluster deployment is unaffected
• These flags are explicitly set to false, so this change introduces no behavioral changes—it's purely preparatory infrastructure work
• Depends on upstream changes in the pod-scaler tool itself (referenced ci-tools PR #4886) which introduce support for these flags

Status:

• PR is on hold pending review from the test platform team
• Awaiting a Jira version assignment for target version 5.0.0

[openshift-ci-robot]

@deepsm007: This pull request references DPTP-2938 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Wires the new authoritative flags on build-cluster pod-scaler admission. Both stay off so nothing changes in behavior yet.

Depends on openshift/ci-tools#4886 — that PR adds --authoritative-cpu and --authoritative-memory to pod-scaler.

Change: clusters/build-clusters/common/pod-scaler/pod-scaler-admission.yaml

• --authoritative-cpu=false
• --authoritative-memory=false

Only the common admission deployment (build01–13 path). vsphere02 is unchanged.

/hold
/cc @openshift/test-platform

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@deepsm007: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1ae29f85-bc9c-49fd-8ea0-9435c28bc8ac

📥 Commits

Reviewing files that changed from the base of the PR and between e62f975 and 2521224.

📒 Files selected for processing (1)

• clusters/build-clusters/common/pod-scaler/pod-scaler-admission.yaml

---

Walkthrough

This PR adds two command-line arguments to the pod-scaler container in the pod-scaler-admission Deployment: --authoritative-cpu=false and --authoritative-memory=false. These flags disable authoritative behavior for CPU and memory resource management.

Changes

Pod-scaler deployment configuration

Layer / File(s)	Summary
Pod-scaler deployment flags clusters/build-clusters/common/pod-scaler/pod-scaler-admission.yaml	The pod-scaler container arguments are extended with two flags to disable authoritative CPU and memory behavior.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately and specifically describes the main change: setting authoritative admission flags to false on the pod-scaler deployment.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies only Kubernetes YAML configuration file (pod-scaler-admission.yaml), not Ginkgo test code. The check for stable test names is not applicable to this change.
Test Structure And Quality	✅ Passed	PR only modifies Kubernetes YAML configuration files (pod-scaler deployments), not Ginkgo test code. The custom check is not applicable to non-test infrastructure changes.
Microshift Test Compatibility	✅ Passed	PR does not add any Ginkgo e2e tests; it only modifies a pod-scaler deployment configuration file with command-line arguments. MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR modifies pod-scaler deployment configuration, not Ginkgo e2e tests. SNO compatibility check applies only to new e2e tests, which this PR does not contain.
Topology-Aware Scheduling Compatibility	✅ Passed	Added arguments are container flags only, not scheduling constraints. Deployment uses 2 replicas with arch/OS-only nodeSelector, no affinity/spread/tolerance rules—topology compatible.
Ote Binary Stdout Contract	✅ Passed	PR modifies only YAML deployment configuration, adding command-line arguments. No source code changes; OTE Binary Stdout Contract check does not apply.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only modifies Kubernetes deployment YAML, not adding Ginkgo e2e tests. Custom check for IPv6/disconnected network compatibility does not apply.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jupierce]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, jupierce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• clusters/build-clusters/common/OWNERS [deepsm007,jupierce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deepsm007]

/unhold

[openshift-ci]

@deepsm007: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.