Skip to content

USHIFT-7041: MicroShift / LVMS CI Doctor - make log file names and copy procedure more generic#79580

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
ggiguash:ci-doctor-reorganize-log-copy
May 26, 2026
Merged

USHIFT-7041: MicroShift / LVMS CI Doctor - make log file names and copy procedure more generic#79580
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
ggiguash:ci-doctor-reorganize-log-copy

Conversation

@ggiguash
Copy link
Copy Markdown
Contributor

@ggiguash ggiguash commented May 21, 2026

Summary by CodeRabbit

This PR updates CI Doctor step scripts in the OpenShift CI release repo for two edge-tooling jobs (MicroShift CI Doctor and LVMS CI Doctor) to standardize log file names, make artifact copying more robust, and tighten session-success validation.

What changed in practical terms

  • Affected CI: ci-operator/step-registry/openshift/edge-tooling — two doctor steps:
    • ci-operator/step-registry/openshift/edge-tooling/lvms-ci/doctor/openshift-edge-tooling-lvms-ci-doctor-commands.sh
    • ci-operator/step-registry/openshift/edge-tooling/microshift-ci/doctor/openshift-edge-tooling-microshift-ci-doctor-commands.sh
  • Log-file naming and capture:
    • LVMS: replaced CLAUDE_ANALYSIS_LOG with CLAUDE_DOCTOR_LOG; the final Claude invocation's verbose output is now teed into CLAUDE_DOCTOR_LOG.
    • MicroShift: introduced per-phase logs (CLAUDE_DOCTOR_LOG, CLAUDE_CREATE_BUGS_LOG, CLAUDE_DOCTOR_REFRESH_LOG) and MCP_JIRA_LOG; each Claude/uvx invocation redirects verbose/stderr output into its dedicated log file via tee/redirection.
  • Artifact copy procedure:
    • Both scripts replace multiple find+cp calls with a single rsync -am --no-perms at exit that includes only explicit file patterns (*.html, *.json, *.txt, .log) and excludes job-specific directories (microshift/ or lvm-operator/), artifacts/, and sosreport directories (sos/) to avoid copying irrelevant or large directories with potentially restrictive permissions.
    • The rsync filter sequence: exclude specific dirs, enter first-level subdirs only (--include='//' --exclude='/'), include target file extensions, exclude everything else, and prune empty dirs (-m).
    • --no-perms prevents permission errors when source files have restrictive ownership (e.g., root-owned sosreport container logs).
  • Exit-time/session validation:
    • LVMS: atexit handler now requires CLAUDE_DOCTOR_LOG to exist, extracts the last JSON line where "type":"result" and fails if that event is missing or not successful (requires "subtype":"success" and "is_error":false).
    • MicroShift: atexit handler checks each per-phase Claude log; missing later-phase logs are treated as warnings (to tolerate timeouts), but present logs must contain a final successful "type":"result" event or the handler fails.
  • Session archiving: both scripts continue to tar and publish Claude session directories into artifacts and set SHARED_DIR flags when archives are present, but the collection is driven by the new rsync-based copy.

Impact

  • More consistent and descriptive per-phase logs, improving diagnosability.
  • A single, explicit rsync-based copy reduces fragile find+cp patterns and prevents unintended directory copies.
  • Depth-limited traversal (first-level subdirs only) and directory exclusions prevent copying large downloaded artifacts (sosreports, project clones) into CI artifacts.
  • Exit validation now depends on machine-readable Claude session logs, improving automated detection of success/failure and making CI outcomes more reliable.

Files changed (high level)

  • lvms-ci-doctor-commands.sh: renamed log variable, switched to rsync with depth-limited filtering, tightened success parsing of CLAUDE_DOCTOR_LOG.
  • microshift-ci-doctor-commands.sh: introduced per-phase log variables and MCP_JIRA_LOG, switched to rsync with depth-limited filtering, added per-log success checks.

Review notes

  • Changes are primarily operational (CI step scripts); no public function signatures were altered.
  • Estimated review effort: Medium — attention recommended on rsync include/exclude ordering and the JSON parsing that determines job success.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 21, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 21, 2026

@ggiguash: This pull request references USHIFT-7041 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

Walkthrough

Two edge-tooling doctor scripts switch to per-phase Claude logs and rsync-based artifact collection; exit-time validation now checks the latest "type":"result" event in the new log files.

Changes

CI Doctor Script Logging Infrastructure Refactor

Layer / File(s) Summary
LVMS CI doctor script logging refactor
ci-operator/step-registry/openshift/edge-tooling/lvms-ci/doctor/openshift-edge-tooling-lvms-ci-doctor-commands.sh
Introduces CLAUDE_DOCTOR_LOG, replaces multiple find ... -exec cp calls with a single rsync -a include/exclude copy for *.html/*.json/*.txt/*.log (excluding lvm-operator/, artifacts/, *sos*/), redirects final Claude --verbose output into CLAUDE_DOCTOR_LOG, and updates exit validation to read the last "type":"result" JSON event from that log and require "subtype":"success" and "is_error":false.
Microshift CI doctor script logging refactor
ci-operator/step-registry/openshift/edge-tooling/microshift-ci/doctor/openshift-edge-tooling-microshift-ci-doctor-commands.sh
Adds per-phase logs CLAUDE_DOCTOR_LOG, CLAUDE_CREATE_BUGS_LOG, CLAUDE_DOCTOR_REFRESH_LOG and MCP_JIRA_LOG; consolidates artifact copying to a single rsync -a include/exclude copy for *.html/*.json/*.txt/*.log (excluding microshift/, artifacts/), updates the completion-check loop to validate the latest "type":"result" from each Claude phase log, changes uvx mcp-atlassian stderr redirect to ${MCP_JIRA_LOG}, and pipes each Claude --verbose output through tee into its corresponding log file.

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels: lgtm, tide/merge-method-squash

Suggested reviewers:

  • kasturinarra
🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main changes: standardizing log file names and the artifact copy procedure for MicroShift and LVMS CI Doctor scripts.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies shell scripts (.sh) only, not Ginkgo test files. Custom check for Ginkgo test name stability is not applicable.
Test Structure And Quality ✅ Passed PR contains only bash shell scripts, not Ginkgo test code. Custom check for Ginkgo test quality is not applicable to this PR.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests were added in this PR. Changes are limited to CI infrastructure shell scripts and build/utility tools. Check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo e2e tests present in PR; only bash CI scripts modified. The SNO test compatibility check is inapplicable to this PR.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies CI infrastructure scripts for log management and artifact collection, not deployment manifests or operator controllers. No topology-aware scheduling constraints are added.
Ote Binary Stdout Contract ✅ Passed PR contains only shell scripts and YAML configuration changes; no OTE binaries, Go code, or test runner modifications. Custom check for OTE binary stdout contract is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies only shell scripts for CI/CD tooling (Claude AI doctor scripts), not Ginkgo e2e tests. The custom check applies only to new Ginkgo tests, which are not present in this PR.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2026
@openshift-ci openshift-ci Bot requested review from eggfoobar and lucaconsalvi May 21, 2026 06:30
@ggiguash
Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

✅ Actions performed

Full review triggered.

@ggiguash
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-eng-edge-tooling-main-microshift-ci-doctor periodic-ci-openshift-eng-edge-tooling-main-lvms-ci-doctor

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/step-registry/openshift/edge-tooling/lvms-ci/doctor/openshift-edge-tooling-lvms-ci-doctor-commands.sh`:
- Around line 18-23: The rsync filter order is wrong: the specific directory
excludes (--exclude='lvm-operator/' and --exclude='artifacts/') are placed after
the catch-all --exclude='*' so they never take effect; update the rsync
invocation (the rsync -a ... command in
openshift-edge-tooling-lvms-ci-doctor-commands.sh) so that the directory
excludes appear before the general --exclude='*' (or convert to explicit
--filter rules) while preserving the existing --include='*/' and file includes,
ensuring lvm-operator/ and artifacts/ are excluded during traversal.

In
`@ci-operator/step-registry/openshift/edge-tooling/microshift-ci/doctor/openshift-edge-tooling-microshift-ci-doctor-commands.sh`:
- Around line 21-26: The rsync filter order is wrong so directory excludes
(--exclude='microshift/' and --exclude='artifacts/') are ineffective; update the
rsync invocation that copies from "${WORKDIR}/" to "${ARTIFACT_DIR}/" so the
directory-specific excludes appear before the general --exclude='*' (e.g., keep
--include='*/' first, then move --exclude='microshift/' and
--exclude='artifacts/' before the --include='*.html'/*.json'/*.txt'/*.log' and
the final --exclude='*') to ensure files inside those directories are not
copied.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 07b9a5fb-af51-4f17-a98a-f5945c1b839e

📥 Commits

Reviewing files that changed from the base of the PR and between 904bfa5 and 1e897ab.

📒 Files selected for processing (2)
  • ci-operator/step-registry/openshift/edge-tooling/lvms-ci/doctor/openshift-edge-tooling-lvms-ci-doctor-commands.sh
  • ci-operator/step-registry/openshift/edge-tooling/microshift-ci/doctor/openshift-edge-tooling-microshift-ci-doctor-commands.sh

@ggiguash
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-eng-edge-tooling-main-microshift-ci-doctor periodic-ci-openshift-eng-edge-tooling-main-lvms-ci-doctor

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@ggiguash
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 21, 2026
@kasturinarra
Copy link
Copy Markdown
Contributor

/pj-rehearse periodic-ci-openshift-eng-edge-tooling-main-microshift-ci-doctor

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@kasturinarra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@ggiguash
Copy link
Copy Markdown
Contributor Author

Looks like there is a problem with the change.
/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@ggiguash, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto 98d41cbfcae9305e4dfb56e2f5396e8bf067af2e due to conflicts
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@ggiguash
Copy link
Copy Markdown
Contributor Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2026
@ggiguash
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-eng-edge-tooling-main-microshift-ci-doctor periodic-ci-openshift-eng-edge-tooling-main-lvms-ci-doctor

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@ggiguash, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't rebase candidate onto 98d41cbfcae9305e4dfb56e2f5396e8bf067af2e due to conflicts

@ggiguash ggiguash marked this pull request as draft May 25, 2026 13:15
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 25, 2026
@ggiguash ggiguash marked this pull request as ready for review May 25, 2026 13:16
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 25, 2026
@openshift-ci openshift-ci Bot requested a review from vanhalenar May 25, 2026 13:17
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@ggiguash, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't rebase candidate onto 98d41cbfcae9305e4dfb56e2f5396e8bf067af2e due to conflicts

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
ci-operator/step-registry/openshift/edge-tooling/lvms-ci/doctor/openshift-edge-tooling-lvms-ci-doctor-commands.sh (2)

46-48: 💤 Low value

Change "WARNING" to "ERROR" for consistency.

The message says "WARNING" but the code returns 1 (error exit code). The message should say "ERROR" to accurately reflect that this is a hard failure.

📝 Proposed fix
     if [ ! -f "${CLAUDE_DOCTOR_LOG}" ]; then
-        echo "WARNING: Log file '${CLAUDE_DOCTOR_LOG}' not found"
+        echo "ERROR: Log file '${CLAUDE_DOCTOR_LOG}' not found"
         return 1
     fi
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/step-registry/openshift/edge-tooling/lvms-ci/doctor/openshift-edge-tooling-lvms-ci-doctor-commands.sh`
around lines 46 - 48, The echo message for the missing log file uses "WARNING"
but the code returns a non-zero error, so update the message to "ERROR" for
consistency: locate the conditional that checks [ ! -f "${CLAUDE_DOCTOR_LOG}" ]
and change the echo string from "WARNING: Log file '${CLAUDE_DOCTOR_LOG}' not
found" to "ERROR: Log file '${CLAUDE_DOCTOR_LOG}' not found" so the printed
severity matches the exit status.

3-3: ⚡ Quick win

Remove set -x to comply with step registry guidelines.

As per coding guidelines, step registry script files must use set -euo pipefail without -x as the default, enabling -x only when actively debugging. While this script doesn't handle sensitive data, the guideline establishes a consistent standard for all step registry scripts.

📋 Proposed fix
-set -x
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/step-registry/openshift/edge-tooling/lvms-ci/doctor/openshift-edge-tooling-lvms-ci-doctor-commands.sh`
at line 3, Replace the top-level "set -x" in
openshift-edge-tooling-lvms-ci-doctor-commands.sh with the standard
step-registry safety flags by removing the "set -x" token and adding "set -euo
pipefail" at the script start; if you need verbose debugging, enable "-x" only
conditionally (e.g., when a DEBUG env var is set) so the explicit "set -x" is no
longer present.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In
`@ci-operator/step-registry/openshift/edge-tooling/lvms-ci/doctor/openshift-edge-tooling-lvms-ci-doctor-commands.sh`:
- Around line 46-48: The echo message for the missing log file uses "WARNING"
but the code returns a non-zero error, so update the message to "ERROR" for
consistency: locate the conditional that checks [ ! -f "${CLAUDE_DOCTOR_LOG}" ]
and change the echo string from "WARNING: Log file '${CLAUDE_DOCTOR_LOG}' not
found" to "ERROR: Log file '${CLAUDE_DOCTOR_LOG}' not found" so the printed
severity matches the exit status.
- Line 3: Replace the top-level "set -x" in
openshift-edge-tooling-lvms-ci-doctor-commands.sh with the standard
step-registry safety flags by removing the "set -x" token and adding "set -euo
pipefail" at the script start; if you need verbose debugging, enable "-x" only
conditionally (e.g., when a DEBUG env var is set) so the explicit "set -x" is no
longer present.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ac31eba8-b5da-4948-87db-661cd6121026

📥 Commits

Reviewing files that changed from the base of the PR and between 1e897ab and 6c41cd0.

📒 Files selected for processing (2)
  • ci-operator/step-registry/openshift/edge-tooling/lvms-ci/doctor/openshift-edge-tooling-lvms-ci-doctor-commands.sh
  • ci-operator/step-registry/openshift/edge-tooling/microshift-ci/doctor/openshift-edge-tooling-microshift-ci-doctor-commands.sh

@ggiguash
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ?

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@ggiguash, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't rebase candidate onto 98d41cbfcae9305e4dfb56e2f5396e8bf067af2e due to conflicts

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@ggiguash, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto 98d41cbfcae9305e4dfb56e2f5396e8bf067af2e due to conflicts
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@ggiguash
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ?

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@ggiguash, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't rebase candidate onto c79c2b137f120870c53c46345aad4a362c0ad852 due to conflicts

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@ggiguash, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto c79c2b137f120870c53c46345aad4a362c0ad852 due to conflicts
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@ggiguash ggiguash force-pushed the ci-doctor-reorganize-log-copy branch from cb5a005 to b611dfc Compare May 25, 2026 16:54
@ggiguash ggiguash force-pushed the ci-doctor-reorganize-log-copy branch from b611dfc to e3fc5b9 Compare May 25, 2026 16:55
@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 25, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@ggiguash: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-eng-edge-tooling-main-microshift-ci-doctor N/A periodic Registry content changed
periodic-ci-openshift-eng-edge-tooling-main-lvms-ci-doctor N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@ggiguash
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-eng-edge-tooling-main-microshift-ci-doctor periodic-ci-openshift-eng-edge-tooling-main-lvms-ci-doctor

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@ggiguash: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-eng-edge-tooling-main-lvms-ci-doctor N/A periodic Registry content changed
periodic-ci-openshift-eng-edge-tooling-main-microshift-ci-doctor N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@kasturinarra
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, kasturinarra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 26, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 26, 2026

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit c62f2c0 into openshift:main May 26, 2026
12 checks passed
@ggiguash ggiguash deleted the ci-doctor-reorganize-log-copy branch May 26, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants