WINC-1939: Standardize cucushift winc OWNERS files to use team aliases#79582
WINC-1939: Standardize cucushift winc OWNERS files to use team aliases#79582rrasouli wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (36)
✅ Files skipped from review due to trivial changes (11)
WalkthroughThis PR replaces individual GitHub usernames with ChangesOWNERS team-based ownership consolidation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rrasouli
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@rrasouli: This pull request references WINC-1939 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rrasouli The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
added
the
rehearsals-ack
Replace individual usernames with winc-approvers/winc-reviewers team aliases across all cucushift/*/winc/ OWNERS files, matching the pattern already used in the windows/ step-registry paths. Also replaces 3 symlinks in aws/upi/ovn/winc/ that incorrectly pointed to the parent aws/OWNERS (non-winc scope) with standalone files. WINC-1939
rrasouli
force-pushed
the
winc-owners-standardize
branch
from
b268b2f to
c50e661
Compare
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@rrasouli: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary
winc-approvers/winc-reviewersteam aliases across allcucushift/*/winc/OWNERS fileswindows/step-registry paths (22 files)aws/upi/ovn/winc/that incorrectly pointed to the parentaws/OWNERS(non-winc scope) with standalone filesFiles Changed (15)
cucushift/winc/OWNERS+upgrade/+prepare/aws/ipi/ovn/winc/(2 files)aws/upi/ovn/winc/(3 files - symlink to real file conversion)azure/ipi/ovn/winc/(2 files)gcp/ipi/ovn/winc/(2 files)nutanix/ipi/ovn/winc/(1 file)vsphere/ipi/proxy/ovn/winc/(2 files)Motivation
Individual usernames in OWNERS files require updates whenever team membership changes. Team aliases (
winc-approvers/winc-reviewers) are managed centrally in the org config, making ownership maintenance consistent and low-effort.JIRA
WINC-1939
Summary by CodeRabbit
This PR standardizes Windows Container (winc) code ownership across OpenShift CI infrastructure by centralizing approver and reviewer assignments to team aliases rather than listing individual GitHub usernames.
What's changing:
The PR updates 30+ OWNERS and workflow metadata files across the cucushift installer registry to replace hardcoded individual reviewers and approvers (such as
jianlinliu,rrasouli,yunjiang29,jfrancoa,weinliu) with two centralized team aliases:winc-approversandwinc-reviewers. This aligns the winc pathway with the pattern already used in thewindows/step-registry paths.Scope:
prepare/, andupgrade/subdirectoriesNotable structural change:
Three symlinks in
aws/upi/ovn/winc/that incorrectly pointed to the parentaws/OWNERS(a non-winc scope) are converted to standalone OWNERS files with proper winc team assignments.Benefit:
Centralizes ownership management — team membership changes now occur in organization configuration rather than requiring updates across numerous OWNERS files. This reduces maintenance overhead and ensures consistency across all winc CI pathways.