Skip to content

Add referenceRelease to ci imagestreams for OCP 4.11–4.22#79592

Open
deepsm007 wants to merge 1 commit into
openshift:mainfrom
deepsm007:reference-release-ci-imagestreams
Open

Add referenceRelease to ci imagestreams for OCP 4.11–4.22#79592
deepsm007 wants to merge 1 commit into
openshift:mainfrom
deepsm007:reference-release-ci-imagestreams

Conversation

@deepsm007
Copy link
Copy Markdown
Contributor

@deepsm007 deepsm007 commented May 21, 2026

Summary

Adds referenceRelease and referenceMode: source to ci release configs for 4.11 and 4.13–4.22, matching what 4.12 already has on main (openshift/release#79539).

That lets the release-controller assemble CI payloads from quay-proxy (quay-proxy.ci.openshift.org/openshift/ci) instead of only the in-cluster imagestream.

Files

core-services/release-controller/_releases/release-ocp-*-ci.json for:

  • 4.11, 4.13, 4.14, 4.15, 4.16, 4.17, 4.18, 4.19, 4.20, 4.21, 4.22

Each gets the same block as 4.12:

"referenceRelease": {
  "pushRepository": "quay.io/openshift/ci",
  "pullRepository": "quay-proxy.ci.openshift.org/openshift/ci",
  "secretName": "release-controller-quay-mirror-secret"
},
"referenceMode": "source"

Dependency

/hold until openshift/ci-tools#5198 is merged and the updated ci-operator image is in use.

/cc @bradmwilliams @AlexNPavel @openshift/test-platform

@openshift-ci openshift-ci Bot requested review from a team, AlexNPavel and bradmwilliams May 21, 2026 10:55
@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 21, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

Walkthrough

This PR updates OpenShift release configurations across OCP versions 4.11 through 4.22 to add reference release mirroring. Each release file receives a referenceRelease configuration block specifying the CI repository endpoints and authentication credentials needed for centralized image mirroring.

Changes

CI Reference Release Configuration

Layer / File(s) Summary
CI reference release configuration across OCP releases
core-services/release-controller/_releases/release-ocp-4.11-ci.json, release-ocp-4.13-ci.json, release-ocp-4.14-ci.json, release-ocp-4.15-ci.json, release-ocp-4.16-ci.json, release-ocp-4.17-ci.json, release-ocp-4.18-ci.json, release-ocp-4.19-ci.json, release-ocp-4.20-ci.json, release-ocp-4.21-ci.json, release-ocp-4.22-ci.json
All 12 OCP release definitions receive identical referenceRelease blocks with pushRepository, pullRepository, and secretName fields pointing to the same CI mirror endpoints and secret credentials. Selected releases also set referenceMode: "source" for explicit source-based mirroring behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • openshift/release#79539: Adds/configures the referenceRelease block in release-controller CI JSON files for OCP releases with identical structure and values.

Suggested reviewers

  • deads2k
🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Title check ✅ Passed The PR title accurately summarizes the main change: adding referenceRelease configuration to CI imagestreams for OCP versions 4.11–4.22, which is precisely what the changeset accomplishes across 12 JSON release configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains only JSON configuration file changes for release controller settings; no Ginkgo test files or test code present, making this check not applicable.
Test Structure And Quality ✅ Passed PR modifies JSON release configuration files only, not Ginkgo test code. Custom check for test structure is not applicable to configuration-only changes.
Microshift Test Compatibility ✅ Passed PR only modifies release-controller configuration JSON files; no new Ginkgo e2e tests are added. MicroShift compatibility check does not apply to this PR.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only JSON release configuration files with no Ginkgo e2e tests added. The SNO compatibility check applies only to new test code, which is not present.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only JSON release configuration files (metadata for release controller image mirroring), not deployment manifests or operator code. No scheduling constraints introduced.
Ote Binary Stdout Contract ✅ Passed This PR modifies only JSON configuration files in release-controller; no OTE binary or source code changes present that could violate the stdout contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies JSON release configuration files only (release-ocp-*-ci.json). The custom check targets Ginkgo e2e tests (It, Describe, Context, When). No test code was added or modified.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2026
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change 4.10?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's currently "endOfLife": true,

@deepsm007 deepsm007 force-pushed the reference-release-ci-imagestreams branch from e1f4f6d to ee5b3f0 Compare May 21, 2026 18:31
Match 4.12 ci config so release-controller can assemble payloads
from quay-proxy. Skips 4.23 and 5.0 until ci-tools rollout is stable.
@deepsm007 deepsm007 force-pushed the reference-release-ci-imagestreams branch from ee5b3f0 to 9a27a95 Compare May 21, 2026 18:31
@deepsm007 deepsm007 changed the title Enable referenceRelease for remaining ci imagestreams Add referenceRelease to ci imagestreams for OCP 4.11–4.22 May 21, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@deepsm007: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

@deepsm007: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants