Skip to content

Add upgrade lane for TNA and SNO#79596

Open
kasturinarra wants to merge 1 commit into
openshift:mainfrom
kasturinarra:add_upgrade_lane_tna
Open

Add upgrade lane for TNA and SNO#79596
kasturinarra wants to merge 1 commit into
openshift:mainfrom
kasturinarra:add_upgrade_lane_tna

Conversation

@kasturinarra
Copy link
Copy Markdown
Contributor

@kasturinarra kasturinarra commented May 21, 2026

Summary by CodeRabbit

This PR adds two new upgrade test lanes to the OpenShift 5.0 nightly release CI configuration, both targeting RHEL 10 day-2 OS image behavior during cluster upgrades from stable 4.22:

Two-Node Arbiter (TNA) Upgrade Lane

  • Test name: e2e-metal-ovn-two-node-arbiter-upgrade-os-rhel10
  • Purpose: Tests upgrade scenarios on edge-optimized two-node arbiter topology with RHEL 10 day-2 OS images
  • Configuration:
    • Explicit DEVSCRIPTS_CONFIG with IPv4 stack, 2 master nodes (32GB RAM, 100GB disk each), 1 arbiter node (8GB RAM, 50GB disk, 2 vCPUs)
    • Sets FEATURE_SET="TechPreviewNoUpgrade" for tech preview features
    • Configures day-2 OS image stream to use RHEL 10
    • Uses TEST_TYPE: upgrade with baremetalds-two-node-arbiter-upgrade workflow
    • Includes test chain for baremetalds IPI and MCO day-2 OS image stream configuration
    • Runs weekly on Equinix edge enablement infrastructure

AWS Single-Node (SNO) Upgrade Lane

  • Test name: e2e-aws-upgrade-ovn-single-node-os-rhel10
  • Purpose: Tests upgrade scenarios on AWS single-node clusters with RHEL 10 day-2 OS images
  • Configuration:
    • Sets FEATURE_SET: TechPreviewNoUpgrade for tech preview features
    • Configures day-2 OS image stream to use RHEL 10
    • Uses TEST_TYPE: upgrade with openshift-upgrade-aws-single-node workflow
    • Includes explicit test refs for single-node e2e validation and MCO day-2 OS image stream configuration
    • Enables resource watch observer to monitor cluster during upgrade
    • Runs every 7 days on AWS infrastructure

Both configurations validate RHEL 10 OS image compatibility and behavior during OpenShift upgrades from 4.22 to 5.0 across different cluster topologies.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f65a2e64-e8ec-4c8b-ab3c-1528e7de2a8e

📥 Commits

Reviewing files that changed from the base of the PR and between 73b60fd and d092f0d.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-5.0-upgrade-from-stable-4.22.yaml

Walkthrough

Two new upgrade test job variants are added to the release CI configuration: one for metal OVN two-node arbiter and one for AWS single-node, both targeting RHEL 10 day-2 OS image streams with TechPreviewNoUpgrade feature set.

Changes

RHEL 10 Upgrade Test Cases

Layer / File(s) Summary
Metal and AWS RHEL 10 upgrade tests
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0-upgrade-from-stable-4.22.yaml
Adds e2e-metal-ovn-two-node-arbiter-upgrade-os-rhel10 with DEVSCRIPTS_CONFIG (v4, 2 masters, 1 arbiter, sized disks/memory/vCPUs), RHEL 10 image stream override, and TEST_TYPE: upgrade. Also adds e2e-aws-upgrade-ovn-single-node-os-rhel10 setting FEATURE_SET: TechPreviewNoUpgrade and RHEL 10 image stream for AWS single-node upgrade testing.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • openshift/release#79388: Both PRs modify OpenShift CI upgrade job definitions with environment variable configurations for OVN upgrade testing (this PR adds new RHEL 10 day-2 upgrade cases; related PR fixes RHCOS9 upgrade jobs with missing IP_STACK=v4).

Suggested labels

lgtm, approved, rehearsals-ack

Suggested reviewers

  • petr-muller
  • neisw
🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add upgrade lane for TNA and SNO' accurately reflects the main change: adding two new upgrade test cases for RHEL 10 day-2 OS image behavior on Two-Node Arbiter (TNA) and Single-Node OpenShift (SNO) configurations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only YAML CI configuration files, not Ginkgo test code. Custom check for Ginkgo test name stability is not applicable to CI configuration metadata.
Test Structure And Quality ✅ Passed PR adds CI configuration and standard Go unit tests (testing.T), not Ginkgo tests. Check designed for Ginkgo test code is not applicable.
Microshift Test Compatibility ✅ Passed PR adds CI configuration YAML for test execution, not new Ginkgo e2e test code. No test code with It(), Describe(), etc. added, so the MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only adds CI configuration for existing test workflows, not new Ginkgo tests. The custom check applies only when new test code is added; this PR adds none.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies CI test job configuration only, not deployment manifests or operator code. No scheduling constraints found; no affinity, topology spread, node selectors, or PDBs.
Ote Binary Stdout Contract ✅ Passed PR modifies only CI configuration YAML files to add test lanes; does not modify any OTE binary code, so the OTE Binary Stdout Contract check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo e2e tests are added in this PR. Changes are CI configuration YAML files only, which define job parameters for existing test workflows. Custom check not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from hoxhaeris and stbenjam May 21, 2026 11:49
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kasturinarra
Once this PR has been reviewed and has the lgtm label, please assign stbenjam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@kasturinarra: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-metal-ovn-two-node-arbiter-upgrade-os-rhel10 N/A periodic Periodic changed
periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-upgrade-ovn-single-node-os-rhel10 N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@kasturinarra
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-metal-ovn-two-node-arbiter-upgrade-os-rhel10 periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-upgrade-ovn-single-node-os-rhel10

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@kasturinarra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

@kasturinarra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-metal-ovn-two-node-arbiter-upgrade-os-rhel10 d092f0d link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-metal-ovn-two-node-arbiter-upgrade-os-rhel10
ci/rehearse/periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-upgrade-ovn-single-node-os-rhel10 d092f0d link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-upgrade-ovn-single-node-os-rhel10

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant