Skip to content

CCXDEV-15790: add optional runtime extractor test for PRs#79598

Open
opokornyy wants to merge 1 commit into
openshift:mainfrom
opokornyy:CCXDEV-15790-runtime-extractor-test
Open

CCXDEV-15790: add optional runtime extractor test for PRs#79598
opokornyy wants to merge 1 commit into
openshift:mainfrom
opokornyy:CCXDEV-15790-runtime-extractor-test

Conversation

@opokornyy
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Ondrej Pokorny <opokorny@redhat.com>
@opokornyy opokornyy changed the title feat(insights): add optional runtime extractor test for PRs CCXDEV-15790: add optional runtime extractor test for PRs May 21, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 21, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 21, 2026

@opokornyy: This pull request references CCXDEV-15790 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e14a2b34-6c64-4f8f-a3ab-ca1c3ef338d1

📥 Commits

Reviewing files that changed from the base of the PR and between 73b60fd and d604407.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/insights-operator/openshift-insights-operator-master-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/insights-operator/openshift-insights-operator-master.yaml

Walkthrough

A new optional CI test job named insights-runtime-extractor-tests is added to the insights-operator CI configuration. The job runs pytest on GCP infrastructure with the insights_runtime_extractor marker, mounts required credential secrets, sets CPU requests to 100m, enforces a 3-hour timeout, and uses the existing ipi-gcp workflow template.

Changes

insights-runtime-extractor-tests CI Job

Layer / File(s) Summary
New insights-runtime-extractor-tests job definition
ci-operator/config/openshift/insights-operator/openshift-insights-operator-master.yaml
A new optional CI test job is configured with GCP cluster target, pytest.sh execution with the insights_runtime_extractor marker, credential mounts for AWS/Slack/OCM access, 100m CPU resource request, 3-hour timeout, and ipi-gcp workflow reference.

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a new optional CI test job for runtime extractor tests in the PR workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR adds CI config YAML only, no Ginkgo test code. All test identifiers are static: job name 'insights-runtime-extractor-tests' and step name 'test' contain no dynamic values.
Test Structure And Quality ✅ Passed PR adds YAML CI configuration only, not Ginkgo test code. Custom check for Ginkgo test quality is inapplicable; PR runs pytest tests via ci-operator config.
Microshift Test Compatibility ✅ Passed This PR adds a CI test job configuration for a pytest-based test, not a Ginkgo e2e test. The custom check applies only to Ginkgo tests, so it is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only adds pytest CI configuration, not Ginkgo e2e tests. SNO check applies only to new Ginkgo tests, not pytest test configurations.
Topology-Aware Scheduling Compatibility ✅ Passed The PR adds a CI test job configuration without any scheduling constraints (no affinity, topology spread, nodeSelectors, or PDBs) that would affect OpenShift topologies.
Ote Binary Stdout Contract ✅ Passed PR adds only CI configuration (YAML) for a Python pytest-based test job, not Go-based OTE binaries. OTE Binary Stdout Contract check is inapplicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies CI configuration file, not Ginkgo test code. No test definitions present in modified files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from katushiik11 and ncaak May 21, 2026 12:18
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: opokornyy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@opokornyy: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-insights-operator-master-insights-runtime-extractor-tests openshift/insights-operator presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@opokornyy
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-insights-operator-master-insights-runtime-extractor-tests

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@opokornyy: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

@opokornyy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/insights-operator/master/insights-runtime-extractor-tests d604407 link unknown /pj-rehearse pull-ci-openshift-insights-operator-master-insights-runtime-extractor-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@opokornyy
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@opokornyy: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants