Skip to content

Update OWNERS for rhobs steps#79600

Open
simonpasquier wants to merge 1 commit into
openshift:mainfrom
simonpasquier:update-rhobs-steps-owners
Open

Update OWNERS for rhobs steps#79600
simonpasquier wants to merge 1 commit into
openshift:mainfrom
simonpasquier:update-rhobs-steps-owners

Conversation

@simonpasquier
Copy link
Copy Markdown
Contributor

@simonpasquier simonpasquier commented May 21, 2026

Summary

This PR consolidates ownership of the RHOBS (Red Hat Observability Stack) step registry definitions in the OpenShift CI infrastructure. The changes update the approvers and reviewers across multiple RHOBS CI steps and their associated metadata to reflect a new ownership structure.

Changes Made

Ownership Updates Across RHOBS Steps:
The following RHOBS CI step definitions have their OWNERS files and corresponding metadata updated to standardize approvers and reviewers to: danielmellado, jan--f, jgbernalp, and simonpasquier:

  • ci-operator/step-registry/rhobs/ (parent directory)
  • enable-ocp/ step and metadata
  • konflux-catalogsource/ step and metadata
  • obo-test-harness/ step and metadata

Removed Approvers/Reviewers:

  • slashpai, sthaha, lihongyan1 (removed from most steps)
  • Tai-RedHat (removed from konflux-catalogsource)

Minor Fix:
A typo correction in ci-operator/step-registry/rhobs/obo-test-harness/rhobs-obo-test-harness-commands.sh ("requried" → "required").

Impact

The changes standardize CI ownership for Red Hat's observability stack testing infrastructure, ensuring consistent code review and approval responsibilities across multiple related test steps used in the OpenShift CI pipeline.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e2a910c3-dc50-4728-a9c1-5ee637fef4bc

📥 Commits

Reviewing files that changed from the base of the PR and between 73b60fd and e931aed.

📒 Files selected for processing (8)
  • ci-operator/step-registry/rhobs/OWNERS
  • ci-operator/step-registry/rhobs/enable-ocp/OWNERS
  • ci-operator/step-registry/rhobs/enable-ocp/rhobs-enable-ocp-ref.metadata.json
  • ci-operator/step-registry/rhobs/konflux-catalogsource/OWNERS
  • ci-operator/step-registry/rhobs/konflux-catalogsource/rhobs-konflux-catalogsource-ref.metadata.json
  • ci-operator/step-registry/rhobs/obo-test-harness/OWNERS
  • ci-operator/step-registry/rhobs/obo-test-harness/rhobs-obo-test-harness-commands.sh
  • ci-operator/step-registry/rhobs/obo-test-harness/rhobs-obo-test-harness-ref.metadata.json

Walkthrough

This PR updates ownership and approval lists across multiple RHOBS step-registry components by removing deprecated team members and consolidating approvers/reviewers to a consistent set of four maintainers. A minor typo in documentation is also corrected.

Changes

RHOBS Ownership Updates

Layer / File(s) Summary
Root RHOBS ownership
ci-operator/step-registry/rhobs/OWNERS
The root RHOBS OWNERS file approvers and reviewers lists are updated to remove slashpai, sthaha, and lihongyan1, and to add danielmellado alongside retained entries.
enable-ocp component ownership
ci-operator/step-registry/rhobs/enable-ocp/OWNERS, ci-operator/step-registry/rhobs/enable-ocp/rhobs-enable-ocp-ref.metadata.json
The enable-ocp OWNERS file and its corresponding metadata JSON are updated to remove slashpai, sthaha, lihongyan1, and to add jgbernalp, with both lists reflecting danielmellado, jan--f, jgbernalp, and simonpasquier.
konflux-catalogsource component ownership
ci-operator/step-registry/rhobs/konflux-catalogsource/OWNERS, ci-operator/step-registry/rhobs/konflux-catalogsource/rhobs-konflux-catalogsource-ref.metadata.json
The konflux-catalogsource OWNERS file and its corresponding metadata JSON are updated to remove lihongyan1 and Tai-RedHat, and to add danielmellado and jgbernalp, with approvers and reviewers containing the consistent team: danielmellado, jan--f, jgbernalp, and simonpasquier.
obo-test-harness component ownership and documentation
ci-operator/step-registry/rhobs/obo-test-harness/OWNERS, ci-operator/step-registry/rhobs/obo-test-harness/rhobs-obo-test-harness-ref.metadata.json, ci-operator/step-registry/rhobs/obo-test-harness/rhobs-obo-test-harness-commands.sh
The obo-test-harness OWNERS and metadata JSON are updated to remove slashpai, sthaha, lihongyan1, and to finalize approvers and reviewers as the standard four maintainers; a typo in the commands.sh comment is corrected from "requried" to "required".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

lgtm, approved

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Update OWNERS for rhobs steps' directly and accurately summarizes the main change: updating OWNERS files across multiple rhobs-related step registry directories.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains no Ginkgo test definitions. Changes are limited to OWNERS configuration files, JSON metadata, and a shell script with no dynamic test name patterns.
Test Structure And Quality ✅ Passed PR contains no Ginkgo test code. Changes are limited to OWNERS files, shell scripts, YAML, and JSON metadata for CI/CD step configurations. The custom check for test quality is not applicable.
Microshift Test Compatibility ✅ Passed PR updates OWNERS and CI step metadata for rhobs. No Ginkgo e2e tests added (zero .go files, zero test definitions), so MicroShift compatibility check not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. Changes are limited to OWNERS files, CI metadata, and a shell script comment—the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only OWNERS files and metadata JSON files for CI step registry; no deployment manifests, operator code, or controllers are present that could introduce scheduling constraints.
Ote Binary Stdout Contract ✅ Passed PR contains only administrative changes (OWNERS, metadata JSON, YAML config, shell script comment fix) with no OTE binary code, Go test files, or process-level code that could violate stdout contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo e2e tests added in this PR. Changes are only to OWNERS files, metadata JSON, and shell scripts, which do not contain e2e test code.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from jan--f and slashpai May 21, 2026 12:27
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@simonpasquier: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-rhobs-observability-operator-main-observability-operator-e2e rhobs/observability-operator presubmit Registry content changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.18-gcp-coo-stage N/A periodic Registry content changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.17-gcp-coo-stage-dast N/A periodic Registry content changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.19-gcp-coo-stage N/A periodic Registry content changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.21-gcp-interop-coo-production N/A periodic Registry content changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.12-azure-coo-stage N/A periodic Registry content changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.14-azure-coo-stage N/A periodic Registry content changed
periodic-ci-rhobs-observability-operator-main-arm64-ocp-4.16-gcp-coo-stage N/A periodic Registry content changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.21-azure-coo-stage N/A periodic Registry content changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.20-azure-coo-stage N/A periodic Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@simonpasquier
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jan--f
Copy link
Copy Markdown
Contributor

jan--f commented May 21, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

@simonpasquier: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.20-azure-coo-stage e931aed link unknown /pj-rehearse periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.20-azure-coo-stage
ci/rehearse/periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.21-azure-coo-stage e931aed link unknown /pj-rehearse periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.21-azure-coo-stage
ci/rehearse/periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.17-gcp-coo-stage-dast e931aed link unknown /pj-rehearse periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.17-gcp-coo-stage-dast
ci/rehearse/periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.12-azure-coo-stage e931aed link unknown /pj-rehearse periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.12-azure-coo-stage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants