Render URL property values as clickable links#150
Open
zaqifathis wants to merge 1 commit into
Open
Conversation
Property values that are URLs (http/https/www) are now rendered as anchor tags opening in a new tab, instead of plain text. Applies to single and multi-value fields. Values are trimmed before matching so leading/trailing whitespace no longer prevents detection.
Member
|
Do we really want to scan every single attribute value, including numerical and boolean values? This should only be applied to attributes of defined type IfcURIReference (even though checking the type might take more time. I would not match text without a scheme/protocol - hence with just www in the beginning. That is not specific enough and we would have to accept any other domain name as well. Also, the table cell does not need to be passed to the function. Keep the function to enclosing the URL. Thumbs up for escaping HTML. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Property values that are URLs (http/https/www) are now rendered as anchor tags opening in a new tab, instead of plain text. Applies to single and multi-value fields. Values are trimmed before matching so leading/trailing whitespace no longer prevents detection.