Conversation
Member
Author
|
Draft since I want to include this in tests and the container image needs to be pulled separately and we need to wait for It's probably also wise to await the ISO work and changes. |
supakeen
force-pushed
the
bootc-ref
branch
5 times, most recently
from
1a093b9 to
2b75fb8
Compare
`image-builder >= 34` contains experimental support for building a subset of image types from bootable containers. Let's allow passing these options along through the plugin. Using this option will mean that the builder needs access to where the bootable container reference is to be pulled from. It also implies that `podman` is installed in the build root. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
For some bootc image types (installers) it is potentially possible to set a payload reference that is embedded onto the ISO. Let's map that into the plugin as well. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
Use a loop instead of each one separately. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
supakeen
commented
Mar 27, 2026
| # available so there's an option to set it explicitly | ||
| bootc_default_fs = bootc.get("default-fs") | ||
| if bootc_default_fs: | ||
| cmd.extend(["--bootc-defaultfs", bootc_default_fs]) |
Member
Author
There was a problem hiding this comment.
The option is called --bootc-default-fs.
bcl
reviewed
Mar 31, 2026
| for ref in ["ref", "build-ref", "installer-payload-ref"]: | ||
| bootc_ref = bootc.get(ref) | ||
| if bootc_ref: | ||
| cmd.extend(["--bootc-ref", bootc_ref]) |
There was a problem hiding this comment.
Needs to match the type of ref. maybe a map or a tuple to associate the cmdline argument with the bootc field.
Member
Author
There was a problem hiding this comment.
Good catch I had very recently updated this to do a loop and then pushed and forgot. Luckily tests are also failing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
image-builder >= 34contains experimental support for building a subset of image types from bootable containers. Let's allow passing these options along through the plugin. Note that not all of these arguments have made it intoimage-builderyet so this will stay draft for a while.Using this option will mean that the builder needs access to where the bootable container reference(s) are to be pulled from. I'll also have to figure out how to integrate this with pungi (which would/should probably build the container even though I don't think that's the case right now for bootable containers specifically).
Building bootable containers into disks in Koji implies that they are to be distributed to users, this means that the containers must include provisioning tools to be used at first boot as the containers will (hopefully) not contain any credentials.