[fix/recursive-fp-copy] Fix recursive copy in File Provider#1557
Open
felix-schwarz wants to merge 3 commits into
Open
[fix/recursive-fp-copy] Fix recursive copy in File Provider#1557felix-schwarz wants to merge 3 commits into
felix-schwarz wants to merge 3 commits into
Conversation
… for folders (=> observed/expected behaviour by Files.app in iOS 26 when copying folder hierarchies)
- replace bookmark.uuid.UUIDString with bookmark.uuidString across the board - FileProviderExtension: - avoid race condition in -createDirectoryWithName:… by no longer returning early placeholders if online - ensure all OCItems returned to the OS contain their bookmarkUUID so that VFS Item IDs can be properly constructed, returned and resolved
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where trying to copy and paste a whole folder hierarchy into the File Provider could render inconsistent and incomplete results.
Related Issue
https://kiteworks.atlassian.net/browse/SE-1082
owncloud/ios-sdk#162
Types of changes