Updated all usage of AngleDoubleLeftIcon to RhUiDoubleCaretLeftIcon#12381
Open
tlabaj wants to merge 1 commit into
Open
Updated all usage of AngleDoubleLeftIcon to RhUiDoubleCaretLeftIcon#12381tlabaj wants to merge 1 commit into
tlabaj wants to merge 1 commit into
Conversation
tlabaj
requested review from
a team,
nicolethoen and
thatblindgeye
and removed request for
a team
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (19)
✅ Files skipped from review due to trivial changes (14)
WalkthroughThis PR replaces all imports and render sites of AngleDoubleLeftIcon with RhUiDoubleCaretLeftIcon across DualListSelector components/examples, deprecated DualListSelector files, DragDrop examples, Pagination navigation, and associated demo apps. ChangesDualListSelector & related examples
Pagination
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tlabaj
requested review from
a team,
bekah-stephens and
phcox
and removed request for
a team
Collaborator
|
Preview: https://pf-react-pr-12381.surge.sh A11y report: https://pf-react-pr-12381-a11y.surge.sh |
nicolethoen
approved these changes
Apr 27, 2026
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
Looks good - snapshots might need to be updated again
thatblindgeye
approved these changes
Apr 27, 2026
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Can we check if Cor
Contributor
Author
@thatblindgeye Your message got cut off. What do we need to check? |
Contributor
|
lol whoops. Was gonna ask if we can check if Core has an issue to make the same update but then I remembered I had made an issue during my initial single caret updates there. |
bekah-stephens
left a comment
bekah-stephens
left a comment
There was a problem hiding this comment.
I'm having issues pulling up the preview link, so I can't double check. I believe these should be using the micron version of the double caret -- @andrew-ronaldson is this true? I'm assuming most places where an icon has a micron version, we want to use that
3 tasks
3 tasks
kmcfaul
force-pushed
the
angle_double_left_icon
branch
from
89e7703 to
1437cee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: towards #12244
Summary
Replaces all usages of
AngleDoubleLeftIconwithRhUiDoubleCaretLeftIcon(import path:@patternfly/react-icons/dist/esm/icons/rh-ui-double-caret-left-icon) across production code, examples, and demo apps for consistency with the Red Hat UI icon set.Changes
PaginationNavigation“first page” control now usesRhUiDoubleCaretLeftIcon.DualListSelectorand all non–code-connect examples (basic, tooltips, search, tree, complex actions, composable, drag-and-drop variants) plus related.mddocs.demo-app-tsDualListSelector demo screens updated to match.Pagination,PaginationNavigation, deprecatedDualListSelector).Summary by CodeRabbit
Closes #12398