Skip to content

check process status for non-child process #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
masteret wants to merge 4 commits into
base: master
Choose a base branch
from
+137 −8
Open

check process status for non-child process #39

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
420f657
check process status for non-child process
masteret Mar 20, 2017
538430b
adopting code from psutil to determine system type
masteret May 17, 2017
c8b0f7f
add license text to 2nd part of code also
masteret May 17, 2017
dd90b08
add zombie process check for linux
masteret May 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 38 additions & 8 deletions ptyprocess/ptyprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,10 +699,25 @@ def isalive(self):
except OSError as e:
# No child processes
if e.errno == errno.ECHILD:
raise PtyProcessError('isalive() encountered condition ' +
'where "terminated" is 0, but there was no child ' +
'process. Did someone else call waitpid() ' +
'on our process?')
try:
os.kill(self.pid, 0)
except OSError as err:
if err.errno == errno.ESRCH:
# No such process
raise PtyProcessError('isalive() encountered condition ' +
'where "terminated" is 0, but there was no child ' +
'process. Did someone else call waitpid() ' +
'on our process?')
elif err.errno == errno.EPERM:
# Process deny access
raise PtyProcessError('isalive() encountered condition ' +
'where the child process deny access')
Copy link
Copy Markdown

@MountainRider MountainRider May 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe

raise PtyProcessError('isalive() does not have permission to query the process')

else:
# Other possible error
raise err
else:
# Process exists not as child
pid, status = 0, 0
else:
raise

Expand All @@ -717,10 +732,25 @@ def isalive(self):
except OSError as e: # pragma: no cover
# This should never happen...
if e.errno == errno.ECHILD:
raise PtyProcessError('isalive() encountered condition ' +
'that should never happen. There was no child ' +
'process. Did someone else call waitpid() ' +
'on our process?')
try:
os.kill(self.pid, 0)
except OSError as err:
if err.errno == errno.ESRCH:
# No such process
raise PtyProcessError('isalive() encountered condition ' +
'where "terminated" is 0, but there was no child ' +
'process. Did someone else call waitpid() ' +
'on our process?')
elif err.errno == errno.EPERM:
# Process deny access
raise PtyProcessError('isalive() encountered condition ' +
'where the child process deny access')
Copy link
Copy Markdown

@MountainRider MountainRider May 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe

raise PtyProcessError('isalive() does not have permission to query the process')

else:
# Other possible error
raise err
else:
# Process exists not as child
pid, status = 0, 0
else:
raise

Expand Down