Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add constraints in .pgschemaignore #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat: add constraints in .pgschemaignore #430
Changes from 1 commit
e7db36cba2186c1ffc0ba492c1031e70f27c93c495b3fa884File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ConstraintsIgnoreConfigThe doc comment for this type was copied verbatim from
DefaultPrivilegeIgnoreConfigand still describes grantee role names, which is unrelated to constraints. Any reader trying to understand what patterns should look like will be misled into thinking they should supply role names instead of constraint names.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
constraintsignore sectionEvery other ignore category (
tables,views,functions,sequences,privileges,default_privileges) has coverage incmd/ignore_integration_test.go. A foreign-key scenario is the explicit motivation for this PR, yet there are no tests that verify a cross-schema FK is correctly filtered out of the dump/plan output. Without this, a regression (e.g., pattern not matching, scoping bug) would go undetected.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.