Fix phx.auth.gen template#6682
Conversation
Changes the test template created by phx.gen.auth to match the text
it generates for the LiveView ("Sign up" instead of "Register").
|
Fixes #6681 |
|
I’ll look into this soon, but it’s weird since we should have a test verifying this: |
|
I ran this on a fresh project and the tests passed, which was weird because the code in my project was more or less untouched. I was baffled where it was grabbing the "Register" text to pass it until I realized that it's grabbing it from the menu links at the top of the page rather than the main body. Having removed the menu links in my project, that text was no longer there and the test obviously failed. Personally, it seems a bit odd to have the test make assertions matching text from above in the menu links ("Log in" and "Register", with the former also matching the h1 in the main body) as well as in the main body ("Log in with email"). Whether that's intentional, I don't know. |
|
🙌 |
Changes the login_live_test template created by phx.gen.auth to match the text it generates for the corresponding login_live template ("Sign up" instead of "Register").