fix(frankenphp-symfony): add Symfony 8 to composer constraints#192
fix(frankenphp-symfony): add Symfony 8 to composer constraints#192dennismenken wants to merge 1 commit into
Conversation
PR php-runtime#185 ("Update Symfony package versions to include 8.0") updated the Symfony constraints for all other packages in this mono-repo but missed frankenphp-symfony — only the PHPUnit dev-dependency was bumped. The runtime uses stable Symfony interfaces (HttpKernelInterface, TerminableInterface, RunnerInterface, SymfonyRuntime) that are unchanged in Symfony 8.0, so no code changes are required.
|
Following |
1 similar comment
|
Following |
|
Friendly ping on this one 🙂. It's been open since the end of March and there are now a couple of folks following along. The change is just the composer constraint that #185 already applied to every sibling package in the mono-repo, so it should be a quick look. Happy to rebase or address anything if needed. Is there anyone in particular I should tag for a review? |
|
If I understand https://symfony.com/blog/new-in-symfony-7-4-dx-improvements-part-2#automatic-integration-of-frankenphp-worker-mode correclty FrankenPHP Runtime is since Symfony 7.4 and 8.0 part of the Symfony core and make this package so obsolete. So maybe we should better abandoned / deprecated it in favor of offical symfony integration? /cc @dunglas @Nyholm |
|
@dennismenken I read the changes in Symfony version 7.4 and it's no longer necessary to install @alexander-schranz Thank you for the information. |
Summary
PR #185 ("Update Symfony package versions to include 8.0") updated the Symfony constraints for all other packages in this mono-repo but missed
frankenphp-symfony— only the PHPUnit dev-dependency was bumped from^9.5to^10.5.58.This PR adds
|| ^8.0to the three Symfony constraints insrc/frankenphp-symfony/composer.json:symfony/dependency-injectionsymfony/http-kernelsymfony/runtimeWhy no code changes are needed
The runtime consists of two files (
Runtime.php,Runner.php) that only use stable Symfony interfaces:HttpKernelInterfaceTerminableInterfaceRunnerInterfaceSymfonyRuntimeRequestNone of these changed between Symfony 7 and 8. We have been running this package with Symfony 8.0 in production without issues.
Evidence
Comparing the diff of #185 for
frankenphp-symfonyvs other packages:frankenphp-symfony (only PHPUnit bumped):
psr-nyholm (correctly updated in same PR):