Vendor code from plone.app.layout to avoid direct dependency on Classic UI#2020
Vendor code from plone.app.layout to avoid direct dependency on Classic UI#2020davisagli wants to merge 3 commits into
Conversation
|
@davisagli thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
|
Hmm, wouldnt it be better to have one source of truth used by both, plone.app.layout and plone.restapi - deeper in the core then. Actually I am not sure where. But this smells a bit. |
|
That would be great, but I think its not easy because restapi is compatible with Plone 5.2 - 6.2 |
|
Also to me this looks like something that should belong to |
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #
📚 Documentation preview 📚: https://plonerestapi--2020.org.readthedocs.build/