Skip to content

Vendor code from plone.app.layout to avoid direct dependency on Classic UI#2020

Open
davisagli wants to merge 3 commits into
mainfrom
layout-dep
Open

Vendor code from plone.app.layout to avoid direct dependency on Classic UI#2020
davisagli wants to merge 3 commits into
mainfrom
layout-dep

Conversation

@davisagli

@davisagli davisagli commented May 29, 2026

Copy link
Copy Markdown
Member
  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #


📚 Documentation preview 📚: https://plonerestapi--2020.org.readthedocs.build/

@mister-roboto

Copy link
Copy Markdown

@davisagli thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@davisagli

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

@davisagli davisagli changed the title Refactor copying code from plone.app.layout to avoid direct dependency on Classic UI Vendor code from plone.app.layout to avoid direct dependency on Classic UI May 29, 2026
@davisagli davisagli requested review from ale-rt and petschki May 30, 2026 07:55

@petschki petschki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jensens

jensens commented May 31, 2026

Copy link
Copy Markdown
Member

Hmm, wouldnt it be better to have one source of truth used by both, plone.app.layout and plone.restapi - deeper in the core then. Actually I am not sure where. But this smells a bit.

@petschki

Copy link
Copy Markdown
Member

That would be great, but I think its not easy because restapi is compatible with Plone 5.2 - 6.2

@davisagli

Copy link
Copy Markdown
Member Author

@jensens Yeah, I think you are right. Maybe they should go in CMFPlone?

@petschki is right that we still try to keep compatibility with Plone 5, but we can use conditional imports for that.

@ale-rt

ale-rt commented Jun 8, 2026

Copy link
Copy Markdown
Member

Also to me this looks like something that should belong to Products.CMFPlone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants