fix(filters): add WCAG labels to front-end filter form#7562
Open
faisalahammad wants to merge 1 commit into
Open
fix(filters): add WCAG labels to front-end filter form#7562faisalahammad wants to merge 1 commit into
faisalahammad wants to merge 1 commit into
Conversation
PR Summary
|
- Add visible <label> for each pick/taxonomy filter dropdown with 'Filter by {field_label}' text
- Add visible label, placeholder, and aria-label to keyword search input
- Labels customizable via existing pods_form_ui_label_text filter
- Drop placeholder option when label visible (BC: returns when label suppressed)
Fixes pods-framework#7561
e2a7783 to
ecce306
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add visible, programmatically-associated
<label>elements to the front-end filter form rendered byPods::filters(). Fixes WCAG 2.1 "Labels or Instructions" violation.Changes
ui/front/filters.php
Before:
-- Label --placeholder optionAfter:
<label for="pods-form-ui-filter_{name}">Filter by {field_label}</label>linked to its<select>id,placeholder="Search…", andaria-label="Search"pods_form_ui_label_textfilterTesting
[pods name="test_products" template="my_template" filters="category,status"]vendor/bin/codecept run wpunit PodsFiltersLabelsCest PodsFiltersLabelFilterCestScreenshots
Fixes #7561