test: drop hardcoded pytest --basetemp so parallel pixi run test in…#6008
Open
hunger wants to merge 1 commit intoprefix-dev:mainfrom
Open
test: drop hardcoded pytest --basetemp so parallel pixi run test in…#6008hunger wants to merge 1 commit intoprefix-dev:mainfrom
pixi run test in…#6008hunger wants to merge 1 commit intoprefix-dev:mainfrom
Conversation
Contributor
|
I think we did this to ensure the tempdir is on the same drive as the working directory. This enables reflinking which speeds up the tests. You can see that the test duration regressed quite a bit with this PR. |
Contributor
Author
|
@baszalmstra: Good catch! The latest and greatest version appends the PID if the basetemp is unset, that seems to work just as well. |
…vocations don't race xdist.setup_node() calls basetemp.mkdir(mode=0o700) without exist_ok=True. With `--basetemp=pytest-temp` hardcoded in pytest.ini, the second of two concurrent pixi-test invocations panicked with FileExistsError: '/var/home/tobias/src/pixi/pytest-temp' Removing the override falls back to pytest's default /tmp/pytest-of-USER/pytest-N/, which auto-uniquifies per invocation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…vocations don't race
xdist.setup_node() calls basetemp.mkdir(mode=0o700) without exist_ok=True. With
--basetemp=pytest-temphardcoded in pytest.ini, the second of two concurrent pixi-test invocations panicked withFileExistsError: '/var/home/tobias/src/pixi/pytest-temp'
Removing the override falls back to pytest's default /tmp/pytest-of-USER/pytest-N/, which auto-uniquifies per invocation.
How Has This Been Tested?
The unit tests
AI Disclosure
Tools: Claude
Checklist:
schema/model.py.