This repository was archived by the owner on Jul 15, 2026. It is now read-only.
feat: new build tools#91
Open
arzola wants to merge 1 commit into
Open
Conversation
composer.lockPackage changes
Important Metadata Changes
Settings · Docs · Powered by Private Packagist |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request modernizes and streamlines the Excalibur plugin's frontend build and asset management workflow. It migrates from Laravel Mix to Vite (via
pressbooks-build-tools), updates Node and PHP requirements, restructures asset locations, and updates related code to use the new frontend tools package. These changes improve maintainability, developer experience, and compatibility with current tooling.Build system and tooling migration:
vite.config.jsand removingwebpack.mix.js; updates NPM scripts and dependencies inpackage.jsonto usepressbooks-build-toolsv5, and switches Node engine requirement to v22. ([[1]](https://github.com/pressbooks/excalibur/pull/91/files#diff-58e6f63d87181b1c6a8cb6e5f1691df04aa32854456efcd52ca71c8541375d26R1-R9),[[2]](https://github.com/pressbooks/excalibur/pull/91/files#diff-974472aeeb3c0d4802bb4087cf02e9cf5591004b99361954801b10b64d7a1f0bL1-L51),[[3]](https://github.com/pressbooks/excalibur/pull/91/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L4-R30),[[4]](https://github.com/pressbooks/excalibur/pull/91/files#diff-2c8effdf840690ccb88c7e21e56148978c6adb2c6926530c58ff0e47a9588b44L1-R1))pressbooks/mixwithpressbooks/frontend-toolsincomposer.json. ([composer.jsonL19-R21](https://github.com/pressbooks/excalibur/pull/91/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34L19-R21))Asset structure and import updates:
assets/src/, updates imports to use new locations, and ensures SCSS uses the modern@usesyntax. ([[1]](https://github.com/pressbooks/excalibur/pull/91/files#diff-d200670db798b35491a753c7a65a6cd41558cbd6738aa74544c30d6daae034e9R1-R2),[[2]](https://github.com/pressbooks/excalibur/pull/91/files#diff-7668d6b1e4a3d543aaf07495a243074801df66c4a57e28b8b01d2b141d1fb9e5L1-R1))inc/class-admin.phpto use the newPressbooksFrontendTools\AssetsandAssetType, and to enqueue the built JS bundle correctly. ([[1]](https://github.com/pressbooks/excalibur/pull/91/files#diff-7ea4b51e842a1863ff86582979e64534421f4b306842e009fd33edb7bc46541aL6-R7),[[2]](https://github.com/pressbooks/excalibur/pull/91/files#diff-7ea4b51e842a1863ff86582979e64534421f4b306842e009fd33edb7bc46541aL26-L31))These changes collectively bring the plugin's frontend workflow in line with current Pressbooks standards and best practices.