fix: #19527 - add ariaLabel input to breadcrumb component for accessi…#19538
Open
vitopio-prete wants to merge 1 commit intoprimefaces:masterfrom
Open
fix: #19527 - add ariaLabel input to breadcrumb component for accessi…#19538vitopio-prete wants to merge 1 commit intoprimefaces:masterfrom
vitopio-prete wants to merge 1 commit intoprimefaces:masterfrom
Conversation
…or accessibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19527
Description
The
p-breadcrumbcomponent's root<nav>element had no accessible label, causing axe-corelandmark-uniqueviolations when multiple breadcrumb instances appear on the same page.Although the documentation states that
aria-labelcan be passed implicitly to the root, this is not currently the case, the attribute is not forwarded to the inner<nav>, so consumers have no way to set it without DOM manipulation.Changes
ariaLabelinput (string | undefined) onp-breadcrumb, following the same pattern already used in other navigation components such asp-menu[attr.aria-label]="ariaLabel"on the root<nav>elementundefineddefault behaviorUsage
Notes
undefinedto preserve current behavior and avoid unexpected changes for existing consumers. Consumers are expected to provide a meaningful label when needed (following the W3C APG breadcrumb pattern).