Skip to content

fix(skore/progressbar): Disable auto_refresh mode in Jupyterlite where threading is not available #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glemaitre merged 1 commit into from
Apr 30, 2026
Merged

fix(skore/progressbar): Disable auto_refresh mode in Jupyterlite where threading is not available #2847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions skore/src/skore/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@
"PredictionErrorDisplay",
"Project",
"RocCurveDisplay",
"THREADABLE",
"TableReportDisplay",
"TrainTestSplit",
"compare",
Expand All @@ -98,3 +99,15 @@
# Waiting for the merge of https://github.com/Textualize/rich/pull/4104.
force_jupyter=(is_environment_notebook_like() or None),
)


try:
from threading import Thread

thread = Thread()
thread.start()
thread.join()
except Exception:
THREADABLE = False
else:
THREADABLE = True
Comment thread
glemaitre marked this conversation as resolved.
3 changes: 2 additions & 1 deletion skore/src/skore/_utils/_progress_bar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class ProgressBar:
"""Simplified progress bar based on ``rich.Progress``."""

def __init__(self, description: str, total: float | None):
from skore import console
from skore import THREADABLE, console
from skore._config import configuration

progress = Progress(
Expand All @@ -26,6 +26,7 @@ def __init__(self, description: str, total: float | None):
console=console,
expand=False,
transient=True,
auto_refresh=THREADABLE,
disable=(not configuration.show_progress),
)

Expand Down
Loading