feat: adapted idhub and issuer-service helm configurations#1
Open
saudkhan116 wants to merge 1 commit into
Open
feat: adapted idhub and issuer-service helm configurations#1saudkhan116 wants to merge 1 commit into
saudkhan116 wants to merge 1 commit into
Conversation
sb-embeteco
reviewed
May 5, 2026
sb-embeteco
left a comment
sb-embeteco
left a comment
There was a problem hiding this comment.
I have tested issuerservice and identityhub Helm deployments with both consumer and provider configurations. All deployments work with the Helm deployments from the Construct-X EDC Helm-Chart PR, and I was able to execute the transaction flow from the Testbed Bruno collection using them.
Notes:
- Since I'm using Istio as the ingress controller on my cluster, I wasn't able to explicitly test the ingress block in the values files. However, I don't think the changes to the configuration will have a negative impact on the deployment.
- We should include a note in the README files stating that the Tractus-X Helm repository should not be used for the Construct-X deployment, and that the new values files must be explicitly selected using the
-fflag in thehelm installcommand.
There was a problem hiding this comment.
This File is missing a License Header.
There was a problem hiding this comment.
This File is missing a License Header.
| port: 9292 | ||
| path: /api/sts | ||
|
|
||
| didweb: |
There was a problem hiding this comment.
identityhub.didweb.https Block is not mentioned in README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
Briefly describe what your PR changes, which features it adds/modifies.
identityhub-datasource-configto{{ $fullName }}-identityhub-datasource-configidentityhub-configto{{ $fullName }}-identityhub-configname: {{ printf "%s-%s" $fullName $value | quote }}values-stag-ihub-consumer.yaml,values-stag-ihub-provider.yamlandvalues-stag-issuer.yamlregistry.onstackit.cloud/constructx/identityhub-devregistry.onstackit.cloud/constructx/issuerservice-devWHY
Briefly state why the change was necessary.
There is a need to demonstrate the running Identityhub and Issuer Service to perfrom e2e data exchange in Construct-X ecosystem.
FURTHER NOTES
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Closes # <-- insert Issue number if one exists