Skip to content

config: clarify sensitive redirect headers match net/http #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roidelapluie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

config: clarify sensitive redirect headers match net/http #924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions config/http_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1178,10 +1178,8 @@ func originalRequestHost(req *http.Request) string {
}

// sensitiveHeadersOnRedirect lists the headers that must not be forwarded when
// following a redirect to a different host. The first four entries match the
// list stripped by makeHeadersCopier in net/http/client.go; we additionally
// strip the Proxy-* headers, which net/http does not, to avoid leaking proxy
// credentials to an untrusted host.
// following a redirect to a different host. The list matches the one stripped
// by makeHeadersCopier in net/http/client.go.
var sensitiveHeadersOnRedirect = map[string]struct{}{
"Authorization": {},
// "Www-Authenticate" is the canonical form produced by
Expand Down
Loading