config: fix TLSVersion.String() printing pointer address#929
Merged
Conversation
The fallback branch passed the *TLSVersion pointer to fmt.Sprintf("%d"),
so an unknown TLS version (one not in the TLSVersions map) rendered as the
pointer's memory address instead of the numeric version. Dereference the
pointer like the MarshalYAML/MarshalJSON methods already do.
Signed-off-by: Seonghyun Hong <s3onghyun.hong@gmail.com>
roidelapluie
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
TLSVersion.String()falls back tofmt.Sprintf("%d", tv)for a version not present in theTLSVersionsmap — buttvis the*TLSVersionpointer, so it prints the pointer's memory address as a decimal integer instead of the numeric TLS version.The sibling methods
MarshalYAMLandMarshalJSONalready dereference correctly;String()was the lone outlier, and the existing test only covered the known-value path so it was never caught (go vetdoesn't flag it either).Fix
Dereference the pointer:
tv→*tv.Test
Added
TestTLSVersionStringerUnknown. Before the fix it printed a pointer address (e.g."75679541043424"); after, it correctly returns"39321".go test ./config/is green.