Expand ESC vs HashiCorp Vault comparison page#18706
Expand ESC vs HashiCorp Vault comparison page#18706djperlovsky wants to merge 3 commits intomasterfrom
Conversation
Add at-a-glance section, feature comparison table with anchor links, "better together" section with YAML example, and 18 deep-dive sections covering architecture, developer experience, and security. Modeled after the Terraform comparison page structure for SEO. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Waiting to review this with @alexleventer |
Docs reviewSolid expansion overall. The deeper sections add real value over the prior page, and the markdown table is much easier to scan than the HTML version it replaced. A few issues to address before merge: Heading case (must fix)Per
Misleading link (must fix)
Either drop the link or point it at the parent index, e.g.: "easy" / "simpler" — STYLE-GUIDE.mdPer
Table / detail-section consistency
Minor / nits
If you'd like me to take another look after edits, mention @claude. |
|
Your site preview for commit be91026 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18706-be910261.s3-website.us-west-2.amazonaws.com |
Add quotable opening definition, specific data points (provider counts, 90% duplication reduction), customer case study references (Spear AI, Modivcare, Compostable AI), and customer quotes section (Modivcare, Mysten Labs, Tetrate) to improve search and AI discoverability. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use sentence case for H2 headings per style guide. Point dynamic credentials OIDC link to the general configuration guides index instead of the Vault-specific OIDC guide. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
CamSoper
left a comment
There was a problem hiding this comment.
content/docs/esc/vs/vault.md:207 -- only Go and Ruby are HashiCorp-maintained Vault SDKs (source); C#, Python, and Java are community libraries (VaultSharp, hvac, Spring Vault).
Both ESC and Vault provide SDKs for programmatic access. ESC offers TypeScript, Python, and Go SDKs, as well as a REST API. Vault provides Go and Ruby SDKs maintained by HashiCorp, alongside community libraries for C#, Python, and Java. Both platforms enable applications to retrieve secrets at runtime without relying on the CLI.
content/docs/esc/vs/vault.md:58 -- "Users have reduced configuration and secrets duplication by over 90%..." has no source. Either attribute it (Compostable AI is cited later in the page and may fit) or drop the sentence.
content/docs/esc/vs/vault.md:27, 43 vs :58, :147 -- "9+ providers" doesn't match the "9 dynamic secret providers" body text. The actual count under content/docs/esc/integrations/dynamic-secrets/ is 9; pick one phrasing and use it everywhere.
content/docs/esc/vs/vault.md:235-244 -- drop the "What teams are saying" block. Pull-quote testimonials are marketing copy and don't belong on a docs page. The case studies and GA blog are already linked inline at lines 143 and 155 where they back specific technical arguments; that's the right way to cite them here.
content/docs/esc/vs/vault.md:237-238 -- separately from the block above: even if the testimonial section stays in some form, the Zachary Cook quote needs to come out. He left Modivcare and now works at Pulumi, so attributing him with a Modivcare title on a /vs/ page reads as an arms-length customer endorsement when it isn't.
content/docs/esc/vs/vault.md:246-248 -- duplicate CTA. The {{< get-started-esc >}} shortcode at line 127 already covers this.
content/docs/esc/vs/vault.md:45 -- sentence case:
**Key differences**
|
@CamSoper - thanks for taking a look but meant for this to be a draft as I didn't have time to dedicate towards making it prod ready (and just wanted to show something for a separate convo)! Will take you comments in and let you know when its ready |
|
@djperlovsky Sorry about that! I had an itchy trigger finger on my pr-review skill 😆 |
Summary
Expands the existing ESC vs Vault comparison page to match the depth and SEO structure of the Terraform comparison page.
Test plan
make lintpasses (0 errors)make serverenders page at /docs/esc/vs/vault/