Skip to content

docs(rbac): clarify auth_policies:update is sufficient for OIDC policy edits#18805

Open
danbiwer wants to merge 1 commit intomasterfrom
dan/clarify-auth-policies-update-permission
Open

docs(rbac): clarify auth_policies:update is sufficient for OIDC policy edits#18805
danbiwer wants to merge 1 commit intomasterfrom
dan/clarify-auth-policies-update-permission

Conversation

@danbiwer
Copy link
Copy Markdown
Contributor

@danbiwer danbiwer commented May 5, 2026

Summary

  • Updates the auth_policies:update row in the org-settings RBAC scope reference to clarify that this permission alone is sufficient to edit an OIDC auth policy, regardless of the token types (personal, team, organization) the policy references.

…olicies

Documents that the auth_policies:update permission alone gates editing
OIDC auth policies, regardless of the token types referenced by the
policy. Pairs with pulumi/pulumi-service#42376.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@danbiwer danbiwer requested a review from djgrove May 5, 2026 18:36
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 5, 2026

Docs Review

Thanks for tightening this scope description. The clarification about OIDC auth policy editing is useful, but the new wording introduces a few small issues worth a second look before merging.

Issues

1. content/docs/administration/access-identity/rbac/scopes/org-settings.md:124 — sentence reads as a fragment

"Sufficient on its own to edit OIDC auth policies, regardless of the token types they reference." drops its subject and parses awkwardly next to the preceding sentence. Recasting it as a full sentence makes the scope read consistently with the rest of the table.

| `auth_policies:update` | Modify authentication policies and identity provider settings. This permission alone is sufficient to edit OIDC auth policies, regardless of the token types (`personal`, `team`, or `organization`) they reference.<br><br>**Granted by default roles**: `Admin` |

The PR description already calls out the three token types — pulling them into the doc itself spares readers from having to infer what "token types" means in this context.

2. content/docs/administration/access-identity/rbac/scopes/org-settings.md:124 — "OIDC auth policies" carve-out is unexplained

The scope is named auth_policies:update (generic), but the new sentence narrows the clarification to OIDC specifically. A reader will reasonably wonder whether SAML or other auth policies behave differently. If the OIDC-specific note is responding to a real ambiguity (e.g., past confusion about whether tokens:* scopes were also required), consider a short why — e.g., "…even though the policy may govern personal, team, or organization tokens, no additional tokens:* scope is required." If that's not accurate, dropping "OIDC" and saying "auth policies" generally would match the row's heading.

Nits

  • The replaced sentence ("This allows updating security configurations.") was generic but at least set the broad scope of the permission. The new sentence jumps straight to a specific edge case. The suggested rewrite above keeps both the general framing and the OIDC clarification.

Otherwise

  • Single-line content edit; no link, alias, frontmatter, image, or shortcode concerns.
  • No build/infra/code-example surface area touched.
  • No change needed to surrounding rows.

If you'd like another pass after revising, mention @claude.

@pulumi-bot
Copy link
Copy Markdown
Collaborator

@danbiwer danbiwer requested a review from CamSoper May 6, 2026 13:14
Copy link
Copy Markdown
Contributor

@CamSoper CamSoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants