fix(templates): restore missing space in "Available in" line#18828
fix(templates): restore missing space in "Available in" line#18828
Conversation
Hugo's whitespace-trim markers around the items range were eating the
space between "Available in" and the rendered language list, so the
template-page byline rendered as "Available inTypeScript, Python, Go,
C#, YAML". Moved the items computation above the <p> so the visible
markup is a clean "Available in {{ delimit ... }}".
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
@claude take a look pls |
|
Claude finished @alexleventer's task in 1m 1s —— View job ReviewThe fix looks good — clean and minimal. Approving the approach. Why the original was brokenIn the prior layout the The Why the fix worksHoisting the items loop above the The only consumer of this partial is Nits (non-blocking)
Looks good to merge once the test plan checkboxes are walked through manually. |
Docs ReviewSmall, well-scoped Hugo template fix. The diagnosis matches the symptom — the A few notes: Correctness
Suggestions (optional) The partial-level docstring at the top is still accurate, but if you wanted to leave a breadcrumb for the next person who tries to inline the loop back into the Style / conventions
Looks ready to merge once the test-plan checkboxes are confirmed locally. Mention me (@claude) if you want another pass after changes. |
|
Your site preview for commit 5b4a5e0 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18828-5b4a5e05.s3-website.us-west-2.amazonaws.com |
Lighthouse Performance ReportCommit: 5b4a5e0 | Metric definitions
|
Summary
Available inbyline on template pages was rendering asAvailable inTypeScript, Python, Go, C#, YAML— no space between "in" and the first language.{{-/-}}) around the items range were eating the newline/indentation between the literalAvailable intext and the{{ delimit }}call, so they collapsed together at render time.<p>so the visible markup is a cleanAvailable in {{ delimit $items ", " }}. Behavior is identical otherwise — the partial still no-ops whentemplate.languagesisn't set.Affects any page that uses
layouts/templates/template.html(template index/landing pages under/content/templates/...).Test plan
make serveand load a templates page (e.g./templates/container-service/); confirm the byline now reads "Available in TypeScript, Python, Go, C#" with a single space.template.languagesin frontmatter still renders no byline.make lintpasses.🤖 Generated with Claude Code