operations.files.download: reconcile mode/user/group on existing files#1687
Open
wowi42 wants to merge 1 commit intopyinfra-dev:3.xfrom
Open
operations.files.download: reconcile mode/user/group on existing files#1687wowi42 wants to merge 1 commit intopyinfra-dev:3.xfrom
wowi42 wants to merge 1 commit intopyinfra-dev:3.xfrom
Conversation
download() short-circuits to a noop whenever the destination exists (and cache_time / checksums don't say otherwise), so changing the mode, user or group argument had no effect unless you manually deleted the target first. Compare the requested mode/owner against the File fact and emit chmod/chown when they differ; only noop when the file and its metadata both match. Widen the mode parameter's type to int | str | None to match files.file() and let ensure_mode_int() reassignment type-check cleanly. Closes pyinfra-dev#1200.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
download() short-circuits to a noop whenever the destination exists (and cache_time / checksums don't say otherwise), so changing the mode, user or group argument had no effect unless you manually deleted the target first. Compare the requested mode/owner against the File fact and emit chmod/chown when they differ; only noop when the file and its metadata both match.
Widen the mode parameter's type to int | str | None to match files.file() and let ensure_mode_int() reassignment type-check cleanly. Closes #1200.
3.xat this time)scripts/dev-test.sh)scripts/dev-lint.sh)