Melting: Edit bisection algorithm related files#638
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can approve the review once all CodeRabbit's comments are resolved.Enable the |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## melting_structure #638 +/- ##
==================================================
Coverage 84.86% 84.86%
==================================================
Files 44 44
Lines 2504 2504
==================================================
Hits 2125 2125
Misses 379 379 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@prabhath-c Can this be closed? |
Since the basic code has been shifted to using Atoms objects and potential dataframes, I want to now clean up the code with more type hints and good docstrings, and also clearer naming of the functions themselves. I shall make these edits soon on a new branch and then we can close and delete this branch and PR. Would that be okay? |
No description provided.