Skip to content

gh-118158: Fix missing newline in py_compile CLI error output #149008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuanx749 wants to merge 6 commits into
base: main
Choose a base branch
from
+9 −2
Open

gh-118158: Fix missing newline in py_compile CLI error output #149008

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b53ad21
Add test
yuanx749 Apr 26, 2026
885680a
Fix
yuanx749 Apr 26, 2026
af26ddf
Add news
yuanx749 Apr 26, 2026
668abbc
Merge remote-tracking branch 'upstream/main' into py-compile-newline
yuanx749 Apr 26, 2026
9336102
Merge remote-tracking branch 'upstream/main' into py-compile-newline
yuanx749 May 16, 2026
4373a3b
Merge remote-tracking branch 'upstream/main' into py-compile-newline
yuanx749 May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Lib/py_compile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,12 +202,12 @@ def main():
if args.quiet:
parser.exit(1)
else:
parser.exit(1, error.msg)
parser.exit(1, error.msg + '\n')
except OSError as error:
if args.quiet:
parser.exit(1)
else:
parser.exit(1, str(error))
parser.exit(1, str(error) + '\n')


if __name__ == "__main__":
Expand Down
6 changes: 6 additions & 0 deletions Lib/test/test_py_compile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,12 @@ def test_bad_syntax_with_quiet(self):
self.assertEqual(stdout, b'')
self.assertEqual(stderr, b'')

def test_bad_syntax_stderr_ends_with_newline(self):
with open(self.source_path, 'w') as file:
file.write(' print("hello world")\n')
rc, stdout, stderr = self.pycompilecmd_failure(self.source_path)
self.assertTrue(stderr.endswith(b'\n'))

def test_file_not_exists(self):
should_not_exists = os.path.join(os.path.dirname(__file__), 'should_not_exists.py')
rc, stdout, stderr = self.pycompilecmd_failure(self.source_path, should_not_exists)
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2026-04-26-11-25-38.gh-issue-118158.xIy05H.rst
View file
Open in desktop
Copy link
Copy Markdown

@sepehr-rs sepehr-rs May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think it’s standard to add Contributed by in the news entry, and I haven’t seen other CPython issues doing that. But I’ve only started contributing here recently, so I could be missing some context.

Copy link
Copy Markdown
Contributor Author

@yuanx749 yuanx749 May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I followed the example in the devguide:
https://devguide.python.org/getting-started/pull-request-lifecycle/#how-to-write-a-news-entry

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Ensure py_compile CLI error messages end with a newline. Contributed by Xiao Yuan.
Loading