gh-149738: Fix segmentation fault bug in sqllite3

[sepehr-rs]

Fixes #149738.

>>> import sqlite3
>>> db = sqlite3.connect(":memory:")
>>> del db.row_factory
>>> db.execute("test")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
    db.execute("test")
    ~~~~~~~~~~^^^^^^^^
sqlite3.OperationalError: near "test": syntax error
>>> 

• Issue: deleting sqlite3 row_factory causes segfault #149738

[picnixz]

We need tests and check what happens on the created connection after deletion (check that there is still a row factory on the newly created cursor)

[sepehr-rs]

Thanks for your comment and review, @picnixz!
I’ve added the tests as requested and would appreciate any feedback.

P.S. The Read the Docs build is failing, but the logs indicate it’s due to an external issue unrelated to my changes.

[vstinner]

I would prefer using connection_getset instead of connection_members for row_factory and text_factory to raise an exception if the developer tries to delete the attribute (set it to NULL). Add get/set on these attributes.

[sepehr-rs]

Hi @vstinner! Thank you for your kind review. Sorry for the delay, GitHub access has been unreliable here recently.
I’ve made the requested changes and would appreciate your feedback when you have a chance.

[picnixz]

Plesse correct undefined behaviors by changing the getset signatures. There should be no cast to getter/setter.

[picnixz]

The signature is incorrect, it must be (PyObject*, PyObject*, void*) and you must cast self in the body.

[bedevere-app]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[picnixz]

Pleas update the docs of salite3.rst as well to indicate this change using a versionchanged directive.

[picnixz]

Those getsets must be using a critical section as well.