Skip to content

gh-149924 :Increase test coverage for isclose() function with complex numbers #149923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 7 commits into from
Closed

gh-149924 :Increase test coverage for isclose() function with complex numbers #149923

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2ae6fb6
Increase test coverage for isclose() with complex numbers
May 16, 2026
9ea2413
Merge branch 'main' into add-tests-cmath-py
May 17, 2026
e4edb1a
gh-149857: Clarify multiprocessing Process argument wording (GH-149919)
ManiSalahmand May 17, 2026
efc2b19
gh-149916: Restore the commented out part of test_body_encode in test…
serhiy-storchaka May 17, 2026
9748e40
gh-146452: Fix pickle segfault on concurrent mutation of dict in pick…
overlorde May 17, 2026
6230932
gh-149921: Fix reference leaks in _interpchannels and _interpqueues m…
aisk May 17, 2026
c5b8583
Add additional test case for inf,-inf behaviour and fix spacing
May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Lib/test/test_cmath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,9 @@ def test_complex_near_zero(self):
self.assertIsNotClose(0.001-0.001j, 0.001+0.001j, abs_tol=1e-03)

def test_complex_special(self):
self.assertIsClose(complex(INF,INF),complex(INF,INF))
self.assertIsClose(complex(-INF,-INF),complex(-INF,-INF))
self.assertIsNotClose(complex(NAN,NAN),complex(NAN,NAN))
Copy link
Copy Markdown
Member

@sobolevn sobolevn May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.assertIsClose(complex(INF,INF),complex(INF,INF))
self.assertIsClose(complex(-INF,-INF),complex(-INF,-INF))
self.assertIsNotClose(complex(NAN,NAN),complex(NAN,NAN))
self.assertIsClose(complex(INF, INF), complex(INF, INF))
self.assertIsClose(complex(-INF, -INF), complex(-INF, -INF))
self.assertIsNotClose(complex(NAN, NAN), complex(NAN, NAN))

self.assertIsNotClose(INF, INF*1j)
self.assertIsNotClose(INF*1j, INF)
self.assertIsNotClose(INF, -INF)
Expand Down
Loading