Skip to content

Document Float8DynamicActivationFloat8WeightConfig as inference-only#4495

Open
Ashutosh0x wants to merge 1 commit into
pytorch:mainfrom
Ashutosh0x:fix/float8-inference-only-docstring
Open

Document Float8DynamicActivationFloat8WeightConfig as inference-only#4495
Ashutosh0x wants to merge 1 commit into
pytorch:mainfrom
Ashutosh0x:fix/float8-inference-only-docstring

Conversation

@Ashutosh0x

Copy link
Copy Markdown

Summary

Users attempting LoRA training on fp8-quantized bases hit an opaque RuntimeError: derivative for aten::_scaled_mm is not implemented with no guidance. The docstring did not mention that this config only supports inference.

Added a .. note:: block making the inference-only limitation explicit and pointing users to convert_to_float8_training for the training path.

Before

Users discover the limitation only at runtime via a cryptic error.

After

The docstring clearly states:

This config is inference-only. Calling loss.backward() on the output of a model quantized with this config will raise RuntimeError: derivative for aten::_scaled_mm is not implemented. For float8 training, use torchao.float8.convert_to_float8_training instead.

Addresses #4376

Test Plan

Documentation-only change. Verified RST note syntax renders correctly by inspection.

This change was authored with the assistance of an AI coding assistant.

Users attempting LoRA training on fp8-quantized bases hit an opaque
'derivative for aten::_scaled_mm is not implemented' error with no
guidance. The docstring did not mention that this config only
supports inference.

Added a .. note:: block making the inference-only limitation explicit
and pointing users to convert_to_float8_training for the training
path.

Addresses pytorch#4376

Test Plan:
Documentation-only change. Verified RST note syntax renders
correctly by inspection.

This change was authored with the assistance of an AI coding assistant.
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 15, 2026
@pytorch-bot

pytorch-bot Bot commented Jun 15, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4495

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 1 Pending, 2 Unrelated Failures

As of commit ff9d86a with merge base 5647df9 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant