Document Float8DynamicActivationFloat8WeightConfig as inference-only#4495
Open
Ashutosh0x wants to merge 1 commit into
Open
Document Float8DynamicActivationFloat8WeightConfig as inference-only#4495Ashutosh0x wants to merge 1 commit into
Ashutosh0x wants to merge 1 commit into
Conversation
Users attempting LoRA training on fp8-quantized bases hit an opaque 'derivative for aten::_scaled_mm is not implemented' error with no guidance. The docstring did not mention that this config only supports inference. Added a .. note:: block making the inference-only limitation explicit and pointing users to convert_to_float8_training for the training path. Addresses pytorch#4376 Test Plan: Documentation-only change. Verified RST note syntax renders correctly by inspection. This change was authored with the assistance of an AI coding assistant.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4495
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 1 Pending, 2 Unrelated FailuresAs of commit ff9d86a with merge base 5647df9 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Users attempting LoRA training on fp8-quantized bases hit an opaque
RuntimeError: derivative for aten::_scaled_mm is not implementedwith no guidance. The docstring did not mention that this config only supports inference.Added a
.. note::block making the inference-only limitation explicit and pointing users toconvert_to_float8_trainingfor the training path.Before
Users discover the limitation only at runtime via a cryptic error.
After
The docstring clearly states:
Addresses #4376
Test Plan
Documentation-only change. Verified RST note syntax renders correctly by inspection.
This change was authored with the assistance of an AI coding assistant.