Replace print() with logger.info() in fusion_utils.py#4499
Open
Ashutosh0x wants to merge 1 commit into
Open
Conversation
The rope_sdpa_fusion_pass function uses print() for status messages, which produces unsilenceable console output on every torch.compile call. Changed to logger.info() so users can control output via standard logging configuration. Also switched from f-strings to %-style formatting for lazy evaluation (standard practice for logger calls). Partial fix for pytorch#4333 Test Plan: Behavioral change is only in output routing (stdout -> logging). The log messages and their content are unchanged. This change was authored with the assistance of an AI coding assistant.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4499
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
rope_sdpa_fusion_passfunction infusion_utils.pyusesprint()for status messages, which produces unsilenceable console output on everytorch.compilecall. Changed tologger.info()so users can control output via standard logging configuration.Also switched from f-strings to %-style formatting for lazy evaluation (standard practice for logger calls -- the format string is only evaluated if the log level is enabled).
Partial fix for #4333
Test Plan
Behavioral change is only in output routing (stdout -> logging). The log messages and their content are unchanged.
This change was authored with the assistance of an AI coding assistant.