Remove dead code: unused _is_blackwell() in attention/utils.py#4501
Open
Ashutosh0x wants to merge 1 commit into
Open
Remove dead code: unused _is_blackwell() in attention/utils.py#4501Ashutosh0x wants to merge 1 commit into
Ashutosh0x wants to merge 1 commit into
Conversation
_is_blackwell() is defined but never imported or called anywhere in the codebase. Removed to reduce dead code. Partial fix for pytorch#4333 Test Plan: Searched entire codebase for _is_blackwell -- only one hit (the definition itself). No callers or imports exist. This change was authored with the assistance of an AI coding assistant.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4501
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Unrelated FailuresAs of commit cd518c1 with merge base 5647df9 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove dead code:
_is_blackwell()intorchao/prototype/attention/utils.pyis defined but never imported or called anywhere in the codebase.Verified by searching the entire repository -- only one hit exists (the definition itself at line 19). No callers, imports, or references.
Partial fix for #4333 (item #7)
Test Plan
This change was authored with the assistance of an AI coding assistant.